From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: Denis Kirjanov <kda@linux-powerpc.org>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] filter: add bpf_optimize_div()
Date: Thu, 20 Nov 2014 22:57:19 +0100 [thread overview]
Message-ID: <546E63BF.8030000@redhat.com> (raw)
In-Reply-To: <CAMEtUuw1q_=CuZOHqd1WDd8ZE+bo-CNsbQ4rFPgRRVy7H1Q4uA@mail.gmail.com>
On 11/20/2014 10:07 PM, Alexei Starovoitov wrote:
> On Thu, Nov 20, 2014 at 11:42 AM, Denis Kirjanov <kda@linux-powerpc.org> wrote:
...
>> diff --git a/include/linux/filter.h b/include/linux/filter.h
>> index ca95abd..b385637 100644
>> --- a/include/linux/filter.h
>> +++ b/include/linux/filter.h
>> +
>> +static inline int bpf_optimize_div(u32 *k)
>
> 'inline' is unnecessary
Btw, it's a header file here, so it's necessary here.
...
> In general I don't think such optimizations
> belong in kernel at all. User space should be doing this.
+1
next prev parent reply other threads:[~2014-11-20 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 19:42 [PATCH net-next] filter: add bpf_optimize_div() Denis Kirjanov
2014-11-20 21:07 ` Alexei Starovoitov
2014-11-20 21:57 ` Daniel Borkmann [this message]
2014-11-21 9:22 ` Denis Kirjanov
2014-11-20 21:32 ` Daniel Borkmann
2014-11-21 5:46 ` Denis Kirjanov
2014-11-21 10:26 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546E63BF.8030000@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=kda@linux-powerpc.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.