From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id B6DA8E008E5; Thu, 20 Nov 2014 22:07:10 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (sven.ebenfeld[at]gmail.com) * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.41 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 9615AE0086F for ; Thu, 20 Nov 2014 22:07:01 -0800 (PST) Received: by mail-wg0-f41.google.com with SMTP id y19so5594343wgg.28 for ; Thu, 20 Nov 2014 22:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=pT6+7JzZNHGwz5z0DZ4x2FrWzjCHVP76dqefrjLmKHw=; b=KCwFYU1V57QYBSfq++9QKTPRg4vea8V+Q4pZmmefXhHw7rQG1qn4uWSwL/2RTV19Mz xnIq2lPdVWYWdzlw7nZWlp+UkTf3UNvX7Bc8sdlA+ePZ2LMqwOdh8IGBBr5SHUWcm0uz Jg0KmrBe/JxCy/AqVa30DByNk11DI2z46ef1DRvYKRyZdbteU2uwP5ld/vAcTBJTXe8H g76OLb3HhMTQX5S1My4B/52f7Mion7UQSpHsjpfA2N3pd4gX+UOAh717Da0XCNqyWsKH s6h/OhQhWjXxgbi73l3BdOeRR0W/iHmgX5JmVUa4xConSE1WIVb22eaDCPGAk42JJdz1 h+lw== X-Received: by 10.180.21.140 with SMTP id v12mr4552203wie.44.1416550020937; Thu, 20 Nov 2014 22:07:00 -0800 (PST) Received: from [192.168.50.244] (ip-37-24-44-195.hsi14.unitymediagroup.de. [37.24.44.195]) by mx.google.com with ESMTPSA id nd20sm9804704wic.11.2014.11.20.22.06.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Nov 2014 22:07:00 -0800 (PST) Message-ID: <546ED682.1020103@gmail.com> Date: Fri, 21 Nov 2014 07:06:58 +0100 From: Sven Ebenfeld User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Daiane Angolini References: <1415699769-27127-1-git-send-email-sven.ebenfeld@gmail.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH] linux-mfgtool: Prevent overwriting linux-imx deployments X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2014 06:07:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Daiane, Thanks for your comments. Am 19.11.2014 um 16:07 schrieb Daiane Angolini: > Hi Sven Ebenfeld, sorry for delay. > > On Tue, Nov 11, 2014 at 7:56 AM, Sven Ebenfeld wrote: >> When I try building fsl-image-mfgtool-initramfs it builds both, > > Could you, please, use "When building blablabla" instead of using > "When I try building blablabla"? > > Who is the "person" behind "I" in a commit log? Okay, I will not use this wording in my next commit logs. > >> linux-imx and linux-mfgtool. Both recipes are trying to write >> the README... file and KERNEL_IMAGETYPE-file into deploy dir. > > I don´t understand why you add the ... after the README file name. > Would it be possibly avoided? The README file name is quite a long name I tried to avoid mentioning the whole name. But if it's better to mention the whole name for better understanding, I will mention it. Or even leave the whole name away. > >> This leads to an error, that one recipe wants to write files that >> already exist. This patch prevents linux-mfgtool from overwriting >> linux-imx's results. >> >> Signed-off-by: Sven Ebenfeld >> --- >> recipes-kernel/linux/linux-mfgtool.inc | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/recipes-kernel/linux/linux-mfgtool.inc b/recipes-kernel/linux/linux-mfgtool.inc >> index 106a7d9..eaccb44 100644 >> --- a/recipes-kernel/linux/linux-mfgtool.inc >> +++ b/recipes-kernel/linux/linux-mfgtool.inc >> @@ -79,3 +79,29 @@ do_install_append() { >> sysroot_stage_all() { >> : >> } >> + >> +# FIXME: Overwrite kernel_do_deploy as it tries to overwrite (u/z)Image symlink >> +# and DO_NOT...DELETE.txt file. This leads to an error that this recipe > > Here again you use ... > Would you be trying to replace a long file name? > > I understand this is only a workaround for the problem, am I right? Yes, it's only a workaround. Unfortunately I don't know a better way for fixing this, yet. The same problem exists with u-boot. Do you think it's possible to get it merged with a better commit log or do you have a proposal where I should look for a better fix? > > > Daiane > >> +# is trying to install files into an area where those files already exist. >> +kernel_do_deploy() { >> + install -m 0644 ${KERNEL_OUTPUT} ${DEPLOYDIR}/${KERNEL_IMAGE_BASE_NAME}.bin >> + if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then >> + mkdir -p ${D}/lib >> + tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib >> + ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME} >> + fi >> + >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/mfgtool-${KERNEL_IMAGETYPE} >> + >> + cd ${B} >> + # Update deploy directory >> + if [ -e "${KERNEL_OUTPUT}.initramfs" ]; then >> + echo "Copying deploy kernel-initramfs image and setting up links..." >> + initramfs_base_name=${INITRAMFS_BASE_NAME} >> + initramfs_symlink_name=mfgtool-${KERNEL_IMAGETYPE}-initramfs-${MACHINE} >> + install -m 0644 ${KERNEL_OUTPUT}.initramfs ${DEPLOYDIR}/${initramfs_base_name}.bin >> + cd ${DEPLOYDIR} >> + ln -sf ${initramfs_base_name}.bin ${initramfs_symlink_name}.bin >> + fi >> +} >> -- >> 1.8.1.rc3 >> >> -- >> _______________________________________________ >> meta-freescale mailing list >> meta-freescale@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/meta-freescale