All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Meerwald <pmeerw@pmeerw.net>,
	Nikolaus Schulz <nikolaus.schulz@avionic-design.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	"open list:IIO SUBSYSTEM AND..." <linux-iio@vger.kernel.org>,
	Alban Bedel <alban.bedel@avionic-design.de>
Subject: Re: [PATCH 2/2] iio: add driver for the TI DAC8554
Date: Fri, 21 Nov 2014 08:41:18 +0100	[thread overview]
Message-ID: <546EEC9E.2080208@metafoo.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1411201911001.13081@pmeerw.net>

On 11/20/2014 07:19 PM, Peter Meerwald wrote:

>> +static const char * const dac8554_powerdown_modes[] = {
>> +	"hi-z",
>
> hi-z is (not yet) described in ABI/testing/sysfs-bus-iio, you should add
> that

Other drivers call it three_state, so might as well stay with that.

>
>> +	"1kohm_to_gnd",
>> +	"100kohm_to_gnd"
>> +};


  reply	other threads:[~2014-11-21  7:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 16:54 [PATCH 1/2] iio: document ti-dac8554 devicetree bindings Nikolaus Schulz
2014-11-20 16:54 ` Nikolaus Schulz
2014-11-20 16:54 ` [PATCH 2/2] iio: add driver for the TI DAC8554 Nikolaus Schulz
2014-11-20 16:54   ` Nikolaus Schulz
2014-11-20 18:19   ` Peter Meerwald
2014-11-21  7:41     ` Lars-Peter Clausen [this message]
2014-11-21 15:00     ` Nikolaus Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546EEC9E.2080208@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alban.bedel@avionic-design.de \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nikolaus.schulz@avionic-design.de \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.