All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Schmid <schmid@phys.ethz.ch>
To: Chris Mason <clm@fb.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: soft lockup - CPU#0 stuck - Kernel 3.17.2
Date: Fri, 21 Nov 2014 14:01:19 +0100	[thread overview]
Message-ID: <546F379F.8000800@phys.ethz.ch> (raw)
In-Reply-To: <1416008854.25389.12@mail.thefacebook.com>

On 15.11.2014 00:47, Chris Mason wrote:
> 
> Ok, I think this is related to the new fair read/writer lock 
> implementation in the generic kernel code.  btrfs_clear_path_blocking() 
> will end up taking locks outside of the strict locking order the rest 
> of Btrfs uses.  This used to be fine because we hold the blocking lock 
> while we do it, but with the new queued locks we're running into 
> trouble.  We hit a similar bug earlier and I convinced myself the 
> problem was only with btrfs_next_leaf and our trylock.  But it's a 
> bigger problem than I realized.
> 
> So for now I've changed btrfs_clear_path_blocking to honor the rules 
> and fixed up our trylock to make it faster.
> 
> I'm letting a test run on this patch over the weekend, since I don't 
> want any surprises with your backup farm.
> 
> -chris

Hi Chris

Here comes a short feedback.... I applied your patch (Fix lockups from
btrfs_clear_path_blocking) yesterday and my system survived this night! ;-)

Thank you for the quick fix.

Regards Patrick
-- 
Patrick Schmid  <schmid@phys.ethz.ch>     support: +41 44 633 2668
IT Services Group, HPT H 8                voice:   +41 44 633 3997
Departement Physik, ETH Zurich
CH-8093 Zurich, Switzerland

  reply	other threads:[~2014-11-21 13:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 13:32 soft lockup - CPU#0 stuck - Kernel 3.17.2 Patrick Schmid
2014-11-13 14:49 ` Chris Mason
2014-11-13 19:07   ` Patrick Schmid
2014-11-13 19:12     ` Chris Mason
     [not found]       ` <54659FDB.6070300@phys.ethz.ch>
2014-11-14 17:39         ` Chris Mason
2014-11-14 18:23           ` Patrick Schmid
2014-11-14 18:31             ` Chris Mason
2014-11-14 23:47               ` Chris Mason
2014-11-21 13:01                 ` Patrick Schmid [this message]
2014-11-21 13:16                   ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546F379F.8000800@phys.ethz.ch \
    --to=schmid@phys.ethz.ch \
    --cc=clm@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.