Re: [Qemu-devel] [PATCH for-2.2] Revert "qemu-img info: show nocow info"

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

On 11/21/2014 10:05 AM, Kevin Wolf wrote:
> This reverts commit 000c4dfff4d7686e2fba3066a477a1290ed60622.
> 
> The main reason for reverting this commit before the 2.2 release is that
> it adds a QAPI interface that we don't want to keep: The 'nocow' flag
> doesn't generally make sense for block nodes, but only for the raw-posix
> driver. It should therefore be part of ImageInfoSpecific rather than
> ImageInfo.
> 
> The commit contains more problems, but unlike the API stability issue
> they wouldn't justify reverting it.
> 
> Conflicts:
> 	block/qapi.c
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qapi.c         | 26 --------------------------
>  qapi/block-core.json |  5 +----
>  2 files changed, 1 insertion(+), 30 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]