From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH for-4.5 RFC] pygrub: Fix regression from c/s
 d1b93ea, attempt 2
Date: Fri, 21 Nov 2014 12:25:08 -0500
Message-ID: <546F7574.9020005@oracle.com>
References: <1416237586-17785-1-git-send-email-andrew.cooper3@citrix.com>
	<1416499238.14429.39.camel@citrix.com>
	<546E1206.5080403@citrix.com> <1416500123.20161.3.camel@citrix.com>
	<546E1ABB.6090308@oracle.com> <546F3EDD.3020006@citrix.com>
	<20141121170933.GB8314@laptop.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141121170933.GB8314@laptop.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/21/2014 12:09 PM, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 21, 2014 at 01:32:13PM +0000, Andrew Cooper wrote:
>> That does look plausibly like it would fix the issue.
>>
>> However, I can't help but feeing that this is hacking around a broken
>> patch in the first place.
> I cannot think of a reason you would ever feel that way!
> <surreptitiously checks the roll of Xen 4.5 band-aid>
>
> We know that the existing patches work fine for a host of Fedora
> families (15->21) (thought I need to double check that the testing framework
> that we have is using pygrub and not pvgrub), SLESs and RHEL5s, and OL6s.
>
> The ones that I am worried about are the ExtLinux and such which
> I didn't realize would use 'pygrub'.
>
> Thought I just remembered a bug with OL7 grub entries - that is if
> you go in the interactive menu things broke down. Boris, do you
> remember if that was fixed or just 'deferred'?

The only bug that I remember that had to do pygrub and OL7 was the fact 
that pygrub cannot parse grubenv (and therefore it's not really 
OL7-specific).

We decided not to fix it.


-boris