All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhigang Wang <zhigang.x.wang@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, konrad.wilk@oracle.com
Cc: ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.5 2/2] xl: print out partial configuration in long mode of list command
Date: Fri, 21 Nov 2014 13:04:42 -0500	[thread overview]
Message-ID: <546F7EBA.6000207@oracle.com> (raw)
In-Reply-To: <1415960555.21321.28.camel@citrix.com>

On 11/14/2014 05:22 AM, Ian Campbell wrote:
> On Fri, 2014-11-14 at 10:09 +0000, Wei Liu wrote:
>> On Fri, Nov 14, 2014 at 09:59:00AM +0000, Ian Campbell wrote:
>>> On Wed, 2014-11-12 at 17:04 +0000, Wei Liu wrote:
>>>> Unconditionally print out the partial configuration.
>>>
>>> Can you provide an example of what such a configuration looks like?
>>>
>>
>>     {
>>         "domid": 2,
>>         "config": {
>>             "c_info": {
>>                 "name": "s0-raw-vnuma",
>>                 "uuid": "a8bed4ac-a0fe-4166-8eac-feeb007a2110"
>>             },
>>             "b_info": {
>>                 "sched_params": {
>>
>>                 },
>>                 "type.invalid": {
>>
>>                 }
>>             }
>>         }
>>     }
> 
> Great, thanks. I propose to insert this into the commit message as I
> check it in (once I check who's acked it etc)
> 
>> Libxl still complains because it tries to read some nodes that don't
>> exist, so xl will just print it out on stderr. This is the same
>> behaviour as before though.
> 
> I think that's tolerable for 4.5 at least.

I also think this is OK for 4.5.

Konrad: can pickup this for next rc?

Thanks,

Zhigang

  reply	other threads:[~2014-11-21 18:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 17:04 [PATCH for-4.5 0/2] xl/libxl: return and print partial config Wei Liu
2014-11-12 17:04 ` [PATCH for-4.5 1/2] libxl: continue when encounter ERROR_JSON_CONFIG_EMPTY Wei Liu
2014-11-14 10:52   ` Ian Campbell
2014-11-14 10:55     ` Ian Campbell
2014-11-14 11:10       ` Wei Liu
2014-11-14 11:19         ` Ian Campbell
2014-11-17  8:58           ` Wei Liu
2014-11-12 17:04 ` [PATCH for-4.5 2/2] xl: print out partial configuration in long mode of list command Wei Liu
2014-11-14  9:59   ` Ian Campbell
2014-11-14 10:09     ` Wei Liu
2014-11-14 10:22       ` Ian Campbell
2014-11-21 18:04         ` Zhigang Wang [this message]
2014-11-21 18:09           ` Konrad Rzeszutek Wilk
2014-11-21 18:14             ` Wei Liu
2014-11-21 18:25               ` Zhigang Wang
2014-11-14 10:53   ` Ian Campbell
2014-11-14 11:03     ` Wei Liu
2014-11-12 17:18 ` [PATCH for-4.5 0/2] xl/libxl: return and print partial config Konrad Rzeszutek Wilk
2014-11-12 17:28   ` Wei Liu
2014-11-13 18:25     ` Konrad Rzeszutek Wilk
2014-11-12 19:54 ` Zhigang Wang
2014-11-12 20:44   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546F7EBA.6000207@oracle.com \
    --to=zhigang.x.wang@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.