From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhigang Wang Subject: Re: [PATCH for-4.5 2/2] xl: print out partial configuration in long mode of list command Date: Fri, 21 Nov 2014 13:25:01 -0500 Message-ID: <546F837D.1040102@oracle.com> References: <1415811865-19981-1-git-send-email-wei.liu2@citrix.com> <1415811865-19981-3-git-send-email-wei.liu2@citrix.com> <1415959140.21321.21.camel@citrix.com> <20141114100939.GB30599@zion.uk.xensource.com> <1415960555.21321.28.camel@citrix.com> <546F7EBA.6000207@oracle.com> <20141121180907.GA15778@laptop.dumpdata.com> <20141121181403.GB17978@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141121181403.GB17978@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org On 11/21/2014 01:14 PM, Wei Liu wrote: > On Fri, Nov 21, 2014 at 01:09:07PM -0500, Konrad Rzeszutek Wilk wrote: >> On Fri, Nov 21, 2014 at 01:04:42PM -0500, Zhigang Wang wrote: >>> On 11/14/2014 05:22 AM, Ian Campbell wrote: >>>> On Fri, 2014-11-14 at 10:09 +0000, Wei Liu wrote: >>>>> On Fri, Nov 14, 2014 at 09:59:00AM +0000, Ian Campbell wrote: >>>>>> On Wed, 2014-11-12 at 17:04 +0000, Wei Liu wrote: >>>>>>> Unconditionally print out the partial configuration. >>>>>> >>>>>> Can you provide an example of what such a configuration looks like? >>>>>> >>>>> >>>>> { >>>>> "domid": 2, >>>>> "config": { >>>>> "c_info": { >>>>> "name": "s0-raw-vnuma", >>>>> "uuid": "a8bed4ac-a0fe-4166-8eac-feeb007a2110" >>>>> }, >>>>> "b_info": { >>>>> "sched_params": { >>>>> >>>>> }, >>>>> "type.invalid": { >>>>> >>>>> } >>>>> } >>>>> } >>>>> } >>>> >>>> Great, thanks. I propose to insert this into the commit message as I >>>> check it in (once I check who's acked it etc) >>>> >>>>> Libxl still complains because it tries to read some nodes that don't >>>>> exist, so xl will just print it out on stderr. This is the same >>>>> behaviour as before though. >>>> >>>> I think that's tolerable for 4.5 at least. >>> >>> I also think this is OK for 4.5. >>> >>> Konrad: can pickup this for next rc? >> >> Please see http://lists.xen.org/archives/html/xen-devel/2014-11/msg01238.html > > Unfortunately I myself want to retract this series because I don't want > to give special consideration for ERROR_JSON_CONFIG_EMPTY. > > I think all you need is to have such skeleton, right? I can do it in > xl... Yes. I need a skeleton in `xl list -l` to indicate the domain is running. If we can have the info as in `xl list`, that will be great: domid, name, uuid, avail_vcpus, target_memkb # xl list Name ID Mem VCPUs State Time(s) Domain-0 0 856 4 r----- 2758.9 0004fb00000600003f327a843a5f2b72--incoming 7 131 1 --p--- 0.0 Thanks, Zhigang