All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Move init_unused_rings to gem_init_hw
Date: Fri, 21 Nov 2014 19:01:54 +0000	[thread overview]
Message-ID: <546F8C22.3050400@intel.com> (raw)
In-Reply-To: <1416473119-21659-1-git-send-email-daniel.vetter@ffwll.ch>

On 20/11/14 08:45, Daniel Vetter wrote:
> We need to do that every time we resume the rings, not just at load.
> I've overlooked this in my untangling of the ring init code.

Hi Daniel,

another thing that needs untangling in the general maze of init code is
the initialisation of the active and request lists -- Thomas Daniel's
complaint about 11/28 of the s/seqno/request/ patchset was essentially
because John was adding more lists that appear to be redundantly
initialised in multiple places. Please see my followup at
http://lists.freedesktop.org/archives/intel-gfx/2014-November/055856.html

As it looks like you're getting rid of intel_render_ring_init_dri(), if
we could also resolve whether init_ring_lists() is also now redundant,
that would mean there were no duplicated list initialisations :)

Thanks,
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-11-21 19:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 23:33 [PATCH 1/5] drm/i915: s/init()/init_hw()/ in intel_engine_cs Daniel Vetter
2014-11-19 23:33 ` [PATCH 2/5] drm/i915: s/intel_workarouns_ring/intel_render_workarounds/ Daniel Vetter
2014-11-20  8:05   ` Chris Wilson
2014-11-20  9:14     ` Daniel Vetter
2014-11-27 15:07   ` Dave Gordon
2014-11-28 17:53     ` Daniel Vetter
2014-11-19 23:33 ` [PATCH 3/5] drm/i915: Move intel_init_pipe_control out of engine->init_hw Daniel Vetter
2014-11-27 16:02   ` Dave Gordon
2014-11-19 23:33 ` [PATCH 4/5] drm/i915: Only init engines once Daniel Vetter
2014-11-20  8:06   ` Chris Wilson
2014-11-28 12:02   ` Dave Gordon
2014-11-28 17:56     ` Daniel Vetter
2014-11-28 18:43       ` Chris Wilson
2014-11-19 23:33 ` [PATCH 5/5] drm/i915: Flatten engine init control flow Daniel Vetter
2014-11-20  8:10   ` Chris Wilson
2014-11-20  9:19     ` Daniel Vetter
2014-12-01 16:11       ` Dave Gordon
2014-12-01 16:34         ` Daniel Vetter
2014-11-20  8:03 ` [PATCH 1/5] drm/i915: s/init()/init_hw()/ in intel_engine_cs Chris Wilson
2014-11-20  9:11   ` Daniel Vetter
2014-11-20  9:15     ` Chris Wilson
2014-11-20  8:45 ` [PATCH] drm/i915: Move init_unused_rings to gem_init_hw Daniel Vetter
2014-11-21 19:01   ` Dave Gordon [this message]
2014-11-21 20:27     ` Daniel Vetter
2014-12-02 15:39       ` Dave Gordon
2014-11-27 14:36 ` [PATCH 1/5] drm/i915: s/init()/init_hw()/ in intel_engine_cs Dave Gordon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546F8C22.3050400@intel.com \
    --to=david.s.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.