From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH v5 08/24] amdkfd: Add amdkfd skeleton driver Date: Fri, 21 Nov 2014 21:34:45 +0200 Message-ID: <546F93D5.8030704@amd.com> References: <1415471865-1893-1-git-send-email-oded.gabbay@amd.com> <1415471865-1893-9-git-send-email-oded.gabbay@amd.com> <1416565445.6958.3.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0135.outbound.protection.outlook.com [157.56.110.135]) by gabe.freedesktop.org (Postfix) with ESMTP id B9DD06F082 for ; Fri, 21 Nov 2014 11:34:57 -0800 (PST) In-Reply-To: <1416565445.6958.3.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Bolle Cc: Jay Cornwall , Andrew Lewycky , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Evgeny Pinchuk , Alex Deucher List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMS8yMS8yMDE0IDEyOjI0IFBNLCBQYXVsIEJvbGxlIHdyb3RlOgo+IE9uIFNhdCwgMjAx NC0xMS0wOCBhdCAyMDozNyArMDIwMCwgT2RlZCBHYWJiYXkgd3JvdGU6Cj4+IFRoaXMgcGF0Y2gg YWRkcyB0aGUgYW1ka2ZkIHNrZWxldG9uIGRyaXZlci4gVGhlIGRyaXZlciBkb2VzIG5vdGhpbmcg ZXhjZXB0Cj4+IGRlZmluZSBhIC9kZXYva2ZkIGRldmljZS4KPj4KPj4gSXQgcmV0dXJucyAtRU5P REVWIG9uIGFsbCBhbWRrZmQgSU9DVExzLgo+Pgo+PiB2MzogTW92ZSBib29sIGZpZWxkIHRvIHRo ZSBlbmQgb2Ygc3RydWN0dXJlLCByZW1vdmVkIHRoZSBwbWMgaW9jdGxzIGFuZCBhZGRlZAo+PiBh IG1lYW5pbmdmdWwgZXJyb3IgbWVzc2FnZSBmb3IgaW9jdGwgZXJyb3IuCj4+Cj4+IHY1Ogo+Pgo+ PiBDcmVhdGUgYSBuZXcgZm9sZGVyIGRybS9hbWQgYW5kIG1vdmUgYW1ka2ZkIGZyb20gZHJtL3Jh ZGVvbi8gdG8gZHJtL2FtZC8KPj4gUmVtb3ZlIHNjaGVkdWxlcl9jbGFzcyBmcm9tIGtmZF9wcml2 LmggYXMgaXQgd2FzIG5ldmVyIHVzZWQKPj4gQWRkIHNrZWxldG9uIGltcGxlbWVudGF0aW9uIG9m IHRoZSBHZXQgVmVyc2lvbiBJT0NUTAo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBPZGVkIEdhYmJheSA8 b2RlZC5nYWJiYXlAYW1kLmNvbT4KPiAKPiBJdCBzZWVtcyB2NiBvZiB0aGlzIHBhdGNoIGlzIGlu Y2x1ZGVkIGluIHRvZGF5J3MgbGludXgtbmV4dCAoaWUsCj4gbmV4dC0yMDE0MTEyMSkuCj4gCj4+ ICBkcml2ZXJzL2dwdS9kcm0vS2NvbmZpZyAgICAgICAgICAgICAgICAgIHwgICAyICsKPj4gIGRy aXZlcnMvZ3B1L2RybS9NYWtlZmlsZSAgICAgICAgICAgICAgICAgfCAgIDEgKwo+PiAgZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRrZmQvS2NvbmZpZyAgICAgICB8ICAxMCArKwo+PiAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRrZmQvTWFrZWZpbGUgICAgICB8ICAgOSArKwo+PiAgZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRrZmQva2ZkX2NoYXJkZXYuYyB8IDIxMCArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZGV2aWNlLmMgIHwg MTMwICsrKysrKysrKysrKysrKysrKysKPj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tm ZF9tb2R1bGUuYyAgfCAxMDEgKysrKysrKysrKysrKysrCj4+ICBkcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGtmZC9rZmRfcHJpdi5oICAgIHwgIDgxICsrKysrKysrKysrKwo+PiAgOCBmaWxlcyBjaGFu Z2VkLCA1NDQgaW5zZXJ0aW9ucygrKQo+PiBbLi4uXQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRrZmQvS2NvbmZpZyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL0tj b25maWcKPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPj4gaW5kZXggMDAwMDAwMC4uYTJhZTZkNAo+ PiAtLS0gL2Rldi9udWxsCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL0tjb25m aWcKPj4gQEAgLTAsMCArMSwxMCBAQAo+PiArIwo+PiArIyBIZXRlcm9nZW5vdXMgc3lzdGVtIGFy Y2hpdGVjdHVyZSBjb25maWd1cmF0aW9uCj4+ICsjCj4+ICsKPj4gK2NvbmZpZyBIU0FfQU1ECj4+ ICsJdHJpc3RhdGUgIkhTQSBrZXJuZWwgZHJpdmVyIGZvciBBTUQgR1BVIGRldmljZXMiCj4+ICsJ ZGVwZW5kcyBvbiAoRFJNX1JBREVPTiB8fCBEUk1fQU1ER1BVKSAmJiBBTURfSU9NTVVfVjIgJiYg WDg2XzY0Cj4gCj4gVGhlcmUncyBjdXJyZW50bHkgbm8gS2NvbmZpZyBzeW1ib2wgRFJNX0FNREdQ VSAobm9yIGFueXRoaW5nIHNpbWlsYXIpLgo+IFdpbGwgdGhhdCBzeW1ib2wgYmUgYWRkZWQgaW4g YSBmdXR1cmUgcGF0Y2g/Cj4gClRoZSBEUk1fQU1ER1BVIHN5bWJvbCBiZWxvbmdzIHRvIEFNRCdz IG5ldyBMaW51eCBrZXJuZWwgZ3JhcGhpYyBkcml2ZXIsIGNhbGxlZAphbWRncHUuIFRoYXQgZHJp dmVyIGlzIG5vdCB5ZXQgdXBzdHJlYW1lZCwgc28gaXRzIHN5bWJvbCBpcyBub3QgcHJlc2VudCBp biBhbnkKS2NvbmZpZyBmaWxlLiBIb3dldmVyLCBpbnRlcm5hbGx5IHdlIHdvcmsgd2l0aCB0aGF0 IGRyaXZlciBzbyB0aGF0J3Mgd2h5IGl0CmFwcGVhcnMgaW4gbXkgcGF0Y2guCgpJIGNhbiByZW1v dmUgaXQgaWYgaXQgdmlvbGF0ZXMgc29tZSBydWxlLiBJIGhhdmUgbm8gcHJvYmxlbSBhZGRpbmcg aXQgYmFjayBvbmNlCmFtZGdwdSBpcyB1cHN0cmVhbWVkLgoKCU9kZWQKCj4+ICsJZGVmYXVsdCBt Cj4+ICsJaGVscAo+PiArCSAgRW5hYmxlIHRoaXMgaWYgeW91IHdhbnQgdG8gdXNlIEhTQSBmZWF0 dXJlcyBvbiBBTUQgR1BVIGRldmljZXMuCj4gCj4gCj4gUGF1bCBCb2xsZQo+IApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751860AbaKUTe7 (ORCPT ); Fri, 21 Nov 2014 14:34:59 -0500 Received: from mail-bl2on0102.outbound.protection.outlook.com ([65.55.169.102]:63360 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751137AbaKUTe5 (ORCPT ); Fri, 21 Nov 2014 14:34:57 -0500 X-WSS-ID: 0NFEME3-08-8KK-02 X-M-MSG: Message-ID: <546F93D5.8030704@amd.com> Date: Fri, 21 Nov 2014 21:34:45 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Paul Bolle CC: David Airlie , Alex Deucher , Jerome Glisse , , , John Bridgman , Ben Goz , Jay Cornwall , "Evgeny Pinchuk" , Andrew Lewycky , Alexey Skidanov Subject: Re: [PATCH v5 08/24] amdkfd: Add amdkfd skeleton driver References: <1415471865-1893-1-git-send-email-oded.gabbay@amd.com> <1415471865-1893-9-git-send-email-oded.gabbay@amd.com> <1416565445.6958.3.camel@x220> In-Reply-To: <1416565445.6958.3.camel@x220> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(377424004)(199003)(24454002)(51704005)(189002)(377454003)(479174003)(50466002)(33656002)(102836001)(36756003)(65956001)(62966003)(77156002)(20776003)(23676002)(64706001)(47776003)(59896002)(50986999)(54356999)(87266999)(76176999)(65816999)(21056001)(87936001)(106466001)(99396003)(68736004)(110136001)(83506001)(31966008)(80316001)(44976005)(97736003)(19580405001)(19580395003)(95666004)(92726001)(84676001)(4396001)(92566001)(101416001)(120916001)(105586002)(86362001)(107046002)(46102003)(64126003);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR02MB196;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB196; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB196; X-Forefront-PRVS: 0402872DA1 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Oded.Gabbay@amd.com; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB196; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2014 12:24 PM, Paul Bolle wrote: > On Sat, 2014-11-08 at 20:37 +0200, Oded Gabbay wrote: >> This patch adds the amdkfd skeleton driver. The driver does nothing except >> define a /dev/kfd device. >> >> It returns -ENODEV on all amdkfd IOCTLs. >> >> v3: Move bool field to the end of structure, removed the pmc ioctls and added >> a meaningful error message for ioctl error. >> >> v5: >> >> Create a new folder drm/amd and move amdkfd from drm/radeon/ to drm/amd/ >> Remove scheduler_class from kfd_priv.h as it was never used >> Add skeleton implementation of the Get Version IOCTL >> >> Signed-off-by: Oded Gabbay > > It seems v6 of this patch is included in today's linux-next (ie, > next-20141121). > >> drivers/gpu/drm/Kconfig | 2 + >> drivers/gpu/drm/Makefile | 1 + >> drivers/gpu/drm/amd/amdkfd/Kconfig | 10 ++ >> drivers/gpu/drm/amd/amdkfd/Makefile | 9 ++ >> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 210 +++++++++++++++++++++++++++++++ >> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 130 +++++++++++++++++++ >> drivers/gpu/drm/amd/amdkfd/kfd_module.c | 101 +++++++++++++++ >> drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 81 ++++++++++++ >> 8 files changed, 544 insertions(+) >> [...] >> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig >> new file mode 100644 >> index 0000000..a2ae6d4 >> --- /dev/null >> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig >> @@ -0,0 +1,10 @@ >> +# >> +# Heterogenous system architecture configuration >> +# >> + >> +config HSA_AMD >> + tristate "HSA kernel driver for AMD GPU devices" >> + depends on (DRM_RADEON || DRM_AMDGPU) && AMD_IOMMU_V2 && X86_64 > > There's currently no Kconfig symbol DRM_AMDGPU (nor anything similar). > Will that symbol be added in a future patch? > The DRM_AMDGPU symbol belongs to AMD's new Linux kernel graphic driver, called amdgpu. That driver is not yet upstreamed, so its symbol is not present in any Kconfig file. However, internally we work with that driver so that's why it appears in my patch. I can remove it if it violates some rule. I have no problem adding it back once amdgpu is upstreamed. Oded >> + default m >> + help >> + Enable this if you want to use HSA features on AMD GPU devices. > > > Paul Bolle >