From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: dom0 kenrel crashes for openstack + libvirt + libxl Date: Fri, 21 Nov 2014 13:03:33 -0700 Message-ID: <546F9A95.1040909@suse.com> References: <54648EB3.8040703@citrix.com> <1415955718.31613.34.camel@citrix.com> <1416227964.5466.12.camel@citrix.com> <1416475824.14429.1.camel@citrix.com> <1416562126.26869.8.camel@citrix.com> <1416578732.17932.9.camel@citrix.com> <546F49CD.1020907@citrix.com> <1416580373.17932.15.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1416580373.17932.15.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , David Vrabel Cc: libvir-list@redhat.com, xen-devel@lists.xen.org, =?windows-1252?Q?Roger_Pau_Monn=E9?= List-Id: xen-devel@lists.xenproject.org On 11/21/2014 07:32 AM, Ian Campbell wrote: > >From 9f2d8da8264b426f54b92378e9e00973694193d4 Mon Sep 17 00:00:00 2001 > From: Ian Campbell > Date: Fri, 21 Nov 2014 14:00:38 +0000 > Subject: [PATCH] libxl: Allow libxl to find pygrub binary. > > Specifying an explicit path to pygrub (e.g. BINDIR "/pygrub") only works if > Xen and libvirt happen to be installed to the same prefix. A more flexible > approach is to simply specify "pygrub" which will cause libxl to use the > correct path which it knows (since it is built with the same prefix as pygrub). > > This is particular problematic in the Debian packaging, since the Debian Xen > package relocates pygrub into a libexec dir, however I think this change makes > sense upstream. Yep agreed. I forgot about making this change a few weeks back after seeing the following in the logs when not explicitly specifying a bootloader libxl: warning: libxl_bootloader.c:413:bootloader_disk_attached_cb: bootloader='/usr/bin/pygrub' is deprecated; use bootloader='pygrub' instead > > Signed-off-by: Ian Campbell > --- > .gnulib | 2 +- > src/libxl/libxl_conf.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gnulib b/.gnulib > index 9565c3b..2d28074 160000 > --- a/.gnulib > +++ b/.gnulib > @@ -1 +1 @@ > -Subproject commit 9565c3be73eb6d76b7b42a21d68d2e00a62abb6d > +Subproject commit 2d280742a9e30088aa169f53353765d5daafe4c0 ACK and pushed after removing this hunk. Regards, Jim > diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h > index 25f77ea..d7a3971 100644 > --- a/src/libxl/libxl_conf.h > +++ b/src/libxl/libxl_conf.h > @@ -53,7 +53,7 @@ > # define LIBXL_LIB_DIR LOCALSTATEDIR "/lib/libvirt/libxl" > # define LIBXL_SAVE_DIR LIBXL_LIB_DIR "/save" > # define LIBXL_DUMP_DIR LIBXL_LIB_DIR "/dump" > -# define LIBXL_BOOTLOADER_PATH BINDIR "/pygrub" > +# define LIBXL_BOOTLOADER_PATH "pygrub" > > /* libxl interface for setting VCPU affinity changed in 4.5. In fact, a new > * parameter has been added, representative of 'VCPU soft affinity'. If one