All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pkg-cmake.mk: Set CMAKE_SYSTEM_PROCESSOR.
Date: Sat, 22 Nov 2014 01:14:57 +0100	[thread overview]
Message-ID: <546FD581.8000206@openwide.fr> (raw)
In-Reply-To: <CAHXCMMKm5G9VgK4Jj5z711fcPdjLFdhbvFVO0iBaduFT8pCq1w@mail.gmail.com>

Hi Samuel, Volker,

Le 15/11/2014 19:20, Samuel Martin a ?crit :
> Romain, Volker,
> 
> On Sat, Nov 15, 2014 at 6:52 PM, Romain Naour <romain.naour@openwide.fr> wrote:
>> Hi Volker,
>>
>> Le 15/11/2014 18:26, Samuel Martin a ?crit :
>>> Hi Volker,
>>>
>>> On Sat, Nov 15, 2014 at 5:00 PM, Volker Krause <volker.krause@kdab.com> wrote:
>>>> This is rarely needed by packages, but convenient to have when it is.
>>>>
>>
>> There is only one package (openpowerlink) that set this variable in buildroot
>> and the expected value is "x86" or "x86_64".
> 
> Hmm... this is in the openpowerlink source?
> I think it'd better do (to be more robust):
> ---
> string(REGEX REPLACE "i*86" "x86" CMAKE_SYSTEM_PROCESSOR
> ${CMAKE_SYSTEM_PROCESSOR})
> ---
> But that's another story ;-)

I used "if(CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")" instead, because the meaning of
* is not the same as in shell. I had "i6x86"...

I found "^i.86$" in cmake sources:
http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/FindJNI.cmake;h=3dcb0d0aaf019a69766b26db36ddbdab6aee3fa7;hb=HEAD#l46

I send a patch to fix that in openpowerlink sources:
http://patchwork.ozlabs.org/patch/413219/

Best regards,
-- 
Romain Naour

OPEN WIDE Ing?nierie - Paris
23/25, rue Daviel| 75013 PARIS
http://ingenierie.openwide.fr

Le blog des technologies libres et embarqu?es :
http://www.linuxembedded.fr

  parent reply	other threads:[~2014-11-22  0:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 16:00 [Buildroot] [PATCH 1/1] pkg-cmake.mk: Set CMAKE_SYSTEM_PROCESSOR Volker Krause
2014-11-15 17:26 ` Samuel Martin
2014-11-15 17:52   ` Romain Naour
2014-11-15 18:20     ` Samuel Martin
2014-11-16 11:25       ` Volker Krause
2014-11-22  0:14       ` Romain Naour [this message]
2014-11-22  9:19         ` Samuel Martin
2014-11-16  5:33 ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546FD581.8000206@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.