Re: Unused function mac802154_header_parse()

[Varka Bhadram <varkabhadram@gmail.com>]

On Friday 21 November 2014 10:40 PM, Alexander Aring wrote:
> On Fri, Nov 21, 2014 at 09:35:21PM +0530, Varka Bhadram wrote:
>> Hi,
>>
>> There are two header_ops operations defined for mac802154 at [1]. One is for creating header another for parsing.
>>
>> Creation of mac802154_header_create() happening at [2] by using dev_hard_header(), but i did not find dev_parse_header()
>> for header parse by mac802154_header_parse().
>>
>> Am i missing anything.?
>>
> For the dev_parse_header usage:
>
> `grep -r -n "dev_parse_header" net`:
>
> net/packet/af_packet.c:1823:	sll->sll_halen = dev_parse_header(skb, sll->sll_addr);
> net/packet/af_packet.c:2030:	sll->sll_halen = dev_parse_header(skb, sll->sll_addr);
>
> This is used by the packet layer at several places.
>
>
>
> I need to dig more into this. It seems that these callback structure are
> optional because dev_hard_header and dev_parse_header header return 0 if
> they are not implemented.
>
> Also it seems that when af_packet uses dev_hard_header header it could
> be that the control block information is overwritten by packet_skb_cb.
> So it's _maybe_ a bug to add additional parameters over control block
> information for the header_create callback.

My point is that no where mac802154_header_parse() function is called.

This has to be called by dev_parse header().

-- 
Thanks and Regards,
Varka Bhadram.