All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qiao Zhou <zhouqiao@marvell.com>
To: Mark Brown <broonie@kernel.org>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: soc-pcm: skip dpcm path checking with incapable/unready FE
Date: Mon, 24 Nov 2014 09:44:36 +0800	[thread overview]
Message-ID: <54728D84.8040504@marvell.com> (raw)
In-Reply-To: <20141121193201.GN3815@sirena.org.uk>

On 11/22/2014 03:32 AM, Mark Brown wrote:
> On Mon, Nov 17, 2014 at 04:02:57PM +0800, Qiao Zhou wrote:
>> Skip dpcm path checking for playback or capture, if corresponding FE
>> doesn't support playback or capture, or currently is not ready. It
>> can reduce the unnecessary cost to search connected widgets.
>
> Applied, but I did change...
>
>> +		/* skip if FE doesn't do playback */
>> +		if (!fe->cpu_dai->playback_active
>> +		    || !fe->codec_dai->playback_active)
>
> ...this and the corresponding capture comment to say "isn't currently
> playing" - it's not if the front end can play, it's if it is playing
> right now.
>
Mark,

Thanks for the correction.

-- 

Best Regards
Qiao

      reply	other threads:[~2014-11-24  1:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17  8:02 [PATCH] ASoC: soc-pcm: skip dpcm path checking with incapable/unready FE Qiao Zhou
2014-11-21 19:32 ` Mark Brown
2014-11-24  1:44   ` Qiao Zhou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54728D84.8040504@marvell.com \
    --to=zhouqiao@marvell.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.