All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org, intel-linux-scu@intel.com
Subject: Re: [PATCH] libsas: allow async aborts
Date: Mon, 24 Nov 2014 09:52:11 +0100	[thread overview]
Message-ID: <5472F1BB.2000303@suse.de> (raw)
In-Reply-To: <1416818414-19430-1-git-send-email-hch@lst.de>

On 11/24/2014 09:40 AM, Christoph Hellwig wrote:
> We now first try to call ->eh_abort_handler from a work queue, but libsas
> was always failing that for no good reason.  Allow async aborts.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/scsi/libsas/sas_scsi_host.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index 89e8b68..3ebdfaf 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -539,9 +539,6 @@ int sas_eh_abort_handler(struct scsi_cmnd *cmd)
>  	struct Scsi_Host *host = cmd->device->host;
>  	struct sas_internal *i = to_sas_internal(host->transportt);
>  
> -	if (current != host->ehandler)
> -		return FAILED;
> -
>  	if (!i->dft->lldd_abort_task)
>  		return FAILED;
>  
> 
Was about to post a similar patch myself.

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2014-11-24  8:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24  8:40 [PATCH] libsas: allow async aborts Christoph Hellwig
2014-11-24  8:52 ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5472F1BB.2000303@suse.de \
    --to=hare@suse.de \
    --cc=hch@lst.de \
    --cc=intel-linux-scu@intel.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.