From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org, Chen Gang <gang.chen.5i5j@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
James Bottomley <JBottomley@Parallels.com>
Subject: Re: [PATCH] libsas: remove task_collector mode
Date: Mon, 24 Nov 2014 10:01:20 +0100 [thread overview]
Message-ID: <5472F3E0.1040409@suse.de> (raw)
In-Reply-To: <20141124085440.GA19283@lst.de>
On 11/24/2014 09:54 AM, Christoph Hellwig wrote:
>> Why did you not remove the last argument from asd_can_queue() and
>> asd_can_dequeue(), too?
>> With that patch it's always '1' ...
>
> Because I wanted to remove the libsas (mis-)feature and avoid to many boad
> driver changes. Especially for a unmaintained big driver like aic94xx.
>
>> This 'while' loop can go, too.
>
> Same here. Note that this driver never even allowed task collector mode,
> so it was already dead code.
>
Okay.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-24 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 8:41 [PATCH] libsas: remove task_collector mode Christoph Hellwig
2014-11-24 8:51 ` Hannes Reinecke
2014-11-24 8:54 ` Christoph Hellwig
2014-11-24 9:01 ` Hannes Reinecke [this message]
2014-11-24 16:46 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5472F3E0.1040409@suse.de \
--to=hare@suse.de \
--cc=JBottomley@Parallels.com \
--cc=dan.j.williams@intel.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.