From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xsqav-00075o-Un for qemu-devel@nongnu.org; Mon, 24 Nov 2014 05:10:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xsqap-0005RE-Q3 for qemu-devel@nongnu.org; Mon, 24 Nov 2014 05:10:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xsqap-0005Q7-JY for qemu-devel@nongnu.org; Mon, 24 Nov 2014 05:10:03 -0500 Message-ID: <547303F0.5070008@redhat.com> Date: Mon, 24 Nov 2014 11:09:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1415286601-30715-1-git-send-email-ming.lei@canonical.com> <1415286601-30715-2-git-send-email-ming.lei@canonical.com> <546B5551.6030208@redhat.com> <5472FE95.1090503@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi , qemu-devel , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= On 24/11/2014 11:02, Ming Lei wrote: >> > Right, but "-1" is "-EPERM" which doesn't make much sense. I think the >> > right thing to do is to return EAGAIN, and let the owner figure it out. >> > For example, a SCSI device might return a "BUSY" status code. > We can do that, but laio_submit() doesn't return the code to callers. That can be fixed later. But not returning a sensible errno only makes things more complicated later on. Paolo