From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH RESEND 1/7] clk: samsung: exynos4: set parent of sclk_hdmiphy to hdmi Date: Mon, 24 Nov 2014 11:42:55 +0100 Message-ID: <54730BAF.7000907@samsung.com> References: <1416814256-24288-1-git-send-email-a.hajda@samsung.com> <1416814256-24288-2-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:36805 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbaKXKnD (ORCPT ); Mon, 24 Nov 2014 05:43:03 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFJ00918HWBIO30@mailout2.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 24 Nov 2014 10:45:47 +0000 (GMT) In-reply-to: <1416814256-24288-2-git-send-email-a.hajda@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Andrzej Hajda Cc: linux-samsung-soc@vger.kernel.org, Marek Szyprowski , Kukjin Kim , Inki Dae , Tomasz Figa , Tobias Jakobi , Daniel Drake On 24/11/14 08:30, Andrzej Hajda wrote: > sclk_hdmiphy clock is generated by HDMI-PHY and depends on hdmi gate clock. > The patch models this dependency using parent/child hirerarchy. > > The patch fixes issue with system hangs during mixer device access, mixer uses > sclk_hdmiphy descendant clock. > > Signed-off-by: Andrzej Hajda Acked-by: Sylwester Nawrocki I guess it can be merged as a bug fix, however it's not an ideal solution. The proper approach would be probably to have the HDMIPHY driver exposing a clk object. Unfortunately there seems to be no sufficiently documented hardware control sequences available for such a fine-grained hardware control. > --- > drivers/clk/samsung/clk-exynos4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c > index 940f028..88e8c6b 100644 > --- a/drivers/clk/samsung/clk-exynos4.c > +++ b/drivers/clk/samsung/clk-exynos4.c > @@ -505,7 +505,7 @@ static struct samsung_fixed_rate_clock exynos4_fixed_rate_ext_clks[] __initdata > /* fixed rate clocks generated inside the soc */ > static struct samsung_fixed_rate_clock exynos4_fixed_rate_clks[] __initdata = { > FRATE(0, "sclk_hdmi24m", NULL, CLK_IS_ROOT, 24000000), > - FRATE(CLK_SCLK_HDMIPHY, "sclk_hdmiphy", NULL, CLK_IS_ROOT, 27000000), > + FRATE(CLK_SCLK_HDMIPHY, "sclk_hdmiphy", "hdmi", 0, 27000000), > FRATE(0, "sclk_usbphy0", NULL, CLK_IS_ROOT, 48000000), > }; -- Regards, Sylwester