From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] xen-netback: do not report success if xenvif_alloc() fails
Date: Mon, 24 Nov 2014 13:44:58 +0300 [thread overview]
Message-ID: <54730C2A.3020108@ispras.ru> (raw)
In-Reply-To: <20141124100053.GC30053@zion.uk.xensource.com>
On 24.11.2014 13:00, Wei Liu wrote:
> On Sat, Nov 22, 2014 at 01:56:28AM +0300, Alexey Khoroshilov wrote:
>> If xenvif_alloc() failes, netback_probe() reports success as well as
>> "online" uevent is emitted. It does not make any sense, but it just
> Sorry, I don't follow. KOBJ_ONLINE event is not emitted in the event of
> xenvif_alloc fails, is it?
Yes, you are right.
>
>> misleads users.
>>
>> The patch implements propagation of error code if xenvif creation fails.
>>
> This patch not only implements propagation of error code when xenvif
> creation fails, but also when xenbus_scanf fails. You can simply write
> "This patch implements propagation of error code for
> backend_create_xenvif".
>
> The rest of this patch looks good to me. Can you rewrite commit message
> and resubmit, thanks.
Ok.
--
Thank you,
Alexey
next prev parent reply other threads:[~2014-11-24 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 22:56 [PATCH] xen-netback: do not report success if xenvif_alloc() fails Alexey Khoroshilov
2014-11-24 10:00 ` Wei Liu
2014-11-24 10:44 ` Alexey Khoroshilov
2014-11-24 10:44 ` Alexey Khoroshilov [this message]
2014-11-24 10:58 ` [PATCH] xen-netback: do not report success if backend_create_xenvif() fails Alexey Khoroshilov
2014-11-24 10:58 ` Alexey Khoroshilov
2014-11-24 11:03 ` Wei Liu
2014-11-24 11:03 ` Wei Liu
2014-11-24 21:14 ` David Miller
2014-11-24 21:14 ` David Miller
2014-11-24 10:00 ` [PATCH] xen-netback: do not report success if xenvif_alloc() fails Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2014-11-21 22:56 Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54730C2A.3020108@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=ian.campbell@citrix.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.