From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH net-next v4 0/4] netns: allow to identify peer netns Date: Mon, 24 Nov 2014 14:45:48 +0100 Message-ID: <5473368C.5040409@6wind.com> References: <1412257690-31253-1-git-send-email-nicolas.dichtel@6wind.com> <1414682728-4532-1-git-send-email-nicolas.dichtel@6wind.com> <871tpph03k.fsf@x220.int.ebiederm.org> Reply-To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <871tpph03k.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org, stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org, cwang-xCSkyg8dI+0RB7SZvlqPiA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org List-Id: containers.vger.kernel.org TGUgMzAvMTAvMjAxNCAxOTo0MSwgRXJpYyBXLiBCaWVkZXJtYW4gYSDDqWNyaXQgOgo+IE5pY29s YXMgRGljaHRlbCA8bmljb2xhcy5kaWNodGVsQDZ3aW5kLmNvbT4gd3JpdGVzOgo+Cj4+IFRoZSBn b2FsIG9mIHRoaXMgc2VyaWUgaXMgdG8gYmUgYWJsZSB0byBtdWx0aWNhc3QgbmV0bGluayBtZXNz YWdlcyB3aXRoIGFuCj4+IGF0dHJpYnV0ZSB0aGF0IGlkZW50aWZ5IGEgcGVlciBuZXRucy4KPj4g VGhpcyBpcyBuZWVkZWQgYnkgdGhlIHVzZXJsYW5kIHRvIGludGVycHJldCBzb21lIGluZm9ybWF0 aW9ucyBjb250YWluZWQgaW4KPj4gbmV0bGluayBtZXNzYWdlcyAobGlrZSBJRkxBX0xJTksgdmFs dWUsIGJ1dCBhbHNvIHNvbWUgb3RoZXIgYXR0cmlidXRlcyBpbiBjYXNlCj4+IG9mIHgtbmV0bnMg bmV0ZGV2aWNlIChzZWUgYWxzbwo+PiBodHRwOi8vdGhyZWFkLmdtYW5lLm9yZy9nbWFuZS5saW51 eC5uZXR3b3JrLzMxNTkzMy9mb2N1cz0zMTYwNjQgYW5kCj4+IGh0dHA6Ly90aHJlYWQuZ21hbmUu b3JnL2dtYW5lLmxpbnV4Lmtlcm5lbC5jb250YWluZXJzLzI4MzAxL2ZvY3VzPTQyMzkpKS4KPj4K Pj4gSWRzIG9mIHBlZXIgbmV0bnMgYXJlIHNldCBieSB1c2VybGFuZCB2aWEgYSBuZXcgZ2VubCBt ZXNzYWdlcy4gVGhlc2UgaWRzIGFyZQo+PiBzdG9yZWQgcGVyIG5ldG5zIGFuZCBhcmUgbG9jYWwg KGllIG9ubHkgdmFsaWQgaW4gdGhlIG5ldG5zIHdoZXJlIHRoZXkgYXJlIHNldCkuCj4+IFRvIGF2 b2lkIGFsbG9jYXRpbmcgYW4gaW50IGZvciBlYWNoIHBlZXIgbmV0bnMsIEkgdXNlIGlkcl9mb3Jf ZWFjaCgpIHRvIHJldHJpZXZlCj4+IHRoZSBpZCBvZiBhIHBlZXIgbmV0bnMuIE5vdGUgdGhhdCBp dCB3aWxsIGJlIHBvc3NpYmxlIHRvIGFkZCBhIHRhYmxlIChzdHJ1Y3QgbmV0Cj4+IC0+IGlkKSBs YXRlciB0byBvcHRpbWl6ZSB0aGlzIGxvb2t1cCBpZiBuZWVkZWQuCj4+Cj4+IFBhdGNoIDEvNCBp bnRyb2R1Y2VzIHRoZSBuZXRsaW5rIEFQSSBtZWNoYW5pc20gdG8gc2V0IGFuZCBnZXQgdGhlc2Ug aWRzLgo+PiBQYXRjaCAyLzQgYW5kIDMvNCBpbXBsZW1lbnRzIGFuIGV4YW1wbGUgb2YgaG93IHRv IHVzZSB0aGVzZSBpZHMgaW4gcnRuZXRsaW5rCj4+IG1lc3NhZ2VzLiBBbmQgcGF0Y2ggNC80IHNo b3dzIHRoYXQgdGhlIG5ldGxpbmsgbWVzc2FnZXMgY2FuIGJlIHN5bWV0cmljIGJldHdlZW4KPj4g YSBHRVQgYW5kIGEgU0VULgo+Pgo+PiBpcHJvdXRlMiBwYXRjaGVzIGFyZSBhdmFpbGFibGUsIEkg Y2FuIHNlbmQgdGhlbSBvbiBkZW1hbmQuCj4KPiBBIHF1aWNrIHJlcGx5LiAgSSB0aGluayB0aGlz IHBhdGNoc2V0IGlzIGluIHRoZSByaWdodCBnZW5lcmFsIGRpcmVjdGlvbi4KPiBUaGVyZSBhcmUg c29tZSBvZGRiYWxsIGRldGFpbHMgdGhhdCBzZWVtIG9kZC9hd2t3YXJkIHRvIG1lIHN1Y2ggYXMg dXNpbmcKPiBnZW5ldGxpbmsgaW5zdGVhZCBvZiBydG5ldGxpbmsgdG8gZ2V0IGFuZCBzZXQgdGhl IGlkcywgYW5kIG5vdCBoYXZpbmcKPiBpZHMgaWYgdGhleSBhcmUgbm90IHNldCAodGhhdCBmZWVs cyBsaWtlIGEgbWFpbnRlbmFuY2UvdXNhYmlsaXR5IGNoYWxsZW5nZSkuCj4KPiBJIHdvdWxkIGxp a2UgdG8gZ2l2ZSB5b3VyIHBhdGNoZXMgYSBkZWVwIHJldmlldywgYnV0IEkgd29uJ3QgYmUgYWJs ZSB0bwo+IGRvIHRoYXQgZm9yIGEgY291cGxlIG9mIHdlZWtzLiAgSSBhbSBkZWVwIGluIHRoZSBw cm9jZXNzIG9mIG1vdmluZywKPiBhbmQgd2lsbCBiZSBtb3N0bHkgb2ZmbGluZSB1bnRpbCBhYm91 dCB0aGUgTm92IDExdGguCkVyaWMsIGRpZCB5b3UgaGF2ZSBhIGNoYW5jZSB0byBsb29rIGF0IHRo aXM/CgoKUmVnYXJkcywKTmljb2xhcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpDb250YWluZXJzIG1haWxpbmcgbGlzdApDb250YWluZXJzQGxpc3RzLmxp bnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWls bWFuL2xpc3RpbmZvL2NvbnRhaW5lcnM= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbaKXNpy (ORCPT ); Mon, 24 Nov 2014 08:45:54 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:46509 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbaKXNpv (ORCPT ); Mon, 24 Nov 2014 08:45:51 -0500 Message-ID: <5473368C.5040409@6wind.com> Date: Mon, 24 Nov 2014 14:45:48 +0100 From: Nicolas Dichtel Reply-To: nicolas.dichtel@6wind.com Organization: 6WIND User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Eric W. Biederman" CC: netdev@vger.kernel.org, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, davem@davemloft.net, stephen@networkplumber.org, akpm@linux-foundation.org, luto@amacapital.net, cwang@twopensource.com Subject: Re: [PATCH net-next v4 0/4] netns: allow to identify peer netns References: <1412257690-31253-1-git-send-email-nicolas.dichtel@6wind.com> <1414682728-4532-1-git-send-email-nicolas.dichtel@6wind.com> <871tpph03k.fsf@x220.int.ebiederm.org> In-Reply-To: <871tpph03k.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 30/10/2014 19:41, Eric W. Biederman a écrit : > Nicolas Dichtel writes: > >> The goal of this serie is to be able to multicast netlink messages with an >> attribute that identify a peer netns. >> This is needed by the userland to interpret some informations contained in >> netlink messages (like IFLA_LINK value, but also some other attributes in case >> of x-netns netdevice (see also >> http://thread.gmane.org/gmane.linux.network/315933/focus=316064 and >> http://thread.gmane.org/gmane.linux.kernel.containers/28301/focus=4239)). >> >> Ids of peer netns are set by userland via a new genl messages. These ids are >> stored per netns and are local (ie only valid in the netns where they are set). >> To avoid allocating an int for each peer netns, I use idr_for_each() to retrieve >> the id of a peer netns. Note that it will be possible to add a table (struct net >> -> id) later to optimize this lookup if needed. >> >> Patch 1/4 introduces the netlink API mechanism to set and get these ids. >> Patch 2/4 and 3/4 implements an example of how to use these ids in rtnetlink >> messages. And patch 4/4 shows that the netlink messages can be symetric between >> a GET and a SET. >> >> iproute2 patches are available, I can send them on demand. > > A quick reply. I think this patchset is in the right general direction. > There are some oddball details that seem odd/awkward to me such as using > genetlink instead of rtnetlink to get and set the ids, and not having > ids if they are not set (that feels like a maintenance/usability challenge). > > I would like to give your patches a deep review, but I won't be able to > do that for a couple of weeks. I am deep in the process of moving, > and will be mostly offline until about the Nov 11th. Eric, did you have a chance to look at this? Regards, Nicolas