From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v12 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Date: Mon, 24 Nov 2014 22:17:23 +0800 Message-ID: <54733DF3.7020609@rock-chips.com> References: <1415793593-5075-1-git-send-email-andy.yan@rock-chips.com> <1416221635-12797-1-git-send-email-andy.yan@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1416221635-12797-1-git-send-email-andy.yan@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk Cc: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org SGkgWnViYWlyTEssIFJ1c3NlbCBLaW5nLCBHcmVnIEtyb2FoLUhhcnRtYW4gLCBQaGlsaXBwIFph YmVsIGFuZCBEYW5pZWw6CiAgICBEbyB5b3UgaGF2ZSBhbnkgZnVydGhlciBvcGluaW9ucyBvciBz dWdnZXN0aW9ucyBhYm91dCB0aGUKdGhlIGN1cnJlbnQgcGF0Y2ggc2V0PwpPbiAyMDE05bm0MTHm nIgxN+aXpSAxODo1MywgQW5keSBZYW4gd3JvdGU6Cj4gV2UgZm91bmQgRnJlZXNjYWxlIGlteDYg YW5kIFJvY2tjaGlwIHJrMzI4OCBhbmQgSW5nZW5pYyBKWjQ3ODAgKFhidXJzdC9NSVBTKQo+IHVz ZSB0aGUgaW50ZXJmYWNlIGNvbXBhdGlibGUgRGVzaWdud2FyZSBIRE1JIElQLCBidXQgdGhleSBh bHNvIGhhdmUgc29tZQo+IGxpZ2h0bHkgZGlmZmVyZW5jZXMsIHN1Y2ggYXMgcGh5IHBsbCBjb25m aWd1cmF0aW9uLCByZWdpc3RlciB3aWR0aChpbXggaGRtaQo+IHJlZ2lzdGVyIGlzIG9uZSBieXRl LCBidXQgcmszMjg4IGlzIDQgYnl0ZXMgd2lkdGggYW5kIGNhbiBvbmx5IGJlIGFjY2Vzc2VkCj4g Ynkgd29yZCksIDRLIHN1cHBvcnQoaW14NiBkb2Vzbid0IHN1cHBvcnQgNGssIGJ1dCByazMyODgg ZG9lcyksIGFuZCBIRE1JMi4wCj4gc3VwcG9ydC4KPgo+IFRvIHJldXNlIHRoZSBpbXgtaGRtaSBk cml2ZXIsIHdlIG1ha2UgdGhpcyBwYXRjaCBzZXQ6Cj4gKDEpOiBmaXggc29tZSBDb2RpbmdTdHls ZSB3YXJuaW5nIHRvIG1ha2UgY2hlY2twYXRjaCBoYXBweQo+ICgyKTogY29udmVydCBpbXgtaGRt aSB0byBkcm1fYnJpZGdlCj4gKDMpOiBtb3ZlIGlteC1oZG1pIHRvIGJyaWRnZS9kd19oZG1pLCBh bmQgc3BsaXQgcGxhdGZvcm0gc3BlY2lmaWMgY29kZQo+ICg0KTogZXh0ZW5kIGR3X2hkbWkuYyB0 byBzdXBwb3J0IHJrMzI4OCBoZG1pCj4gKDUpOiBhZGQgcm9ja2NoaXAgcmszMjg4IHBsYXRmb3Jt IHNwZWNpZmljIGNvZGUgZHdfaGRtaS1yb2NrY2hpcC5jCj4KPiBDaGFuZ2VzIGluIHYxMjoKPiAt IHJlZmFjdG9yIG9mX25vZGVfcHV0KGRkY19ub2RlKQo+IC0gc3F1YXNoIHBhdGNoIDxjb252ZXJ0 IGR3X2hkbWkgdG8gZHJtX2JyaWRnZT4gJiA8c3BsaXQgaW14IHNvYyBzcGVjaWZpYyBjb2RlIGZy b20gaW14LWhkbWk+Cj4gLSBhZGQgY29tbWVudCBmb3IgdGhlIGRlcGVuZCBvbiBwYXRjaAo+Cj4g Q2hhbmdlcyBpbiB2MTE6Cj4gLSBzcXVhc2ggcGF0Y2ggIDxzcGxpdCBzb21lIHBoeSBjb25maWd1 cmF0aW9uIHRvIHBsYXRmb3JtIGRyaXZlcj4KPiAtIHNwbGl0IGZvcm0gcGF0Y2ggPGR3X2hkbWk6 IGFkZCByazMyODggc3VwcG9ydD4KPiAtIHNwbGl0IGZyb20gcGF0Y2ggPGR3X2hkbWk6IGFkZCBy azMyODggc3VwcG9ydD4KPgo+IENoYW5nZXMgaW4gdjEwOgo+IC0gc3BsaXQgZ2VuZXJpYyBkd19o ZG1pLmMgaW1wcm92ZW1lbnRzIGZyb20gcGF0Y2gjMTEgKGFkZCByazMyODggc3VwcG9ydCkKPiAt IGFkZCBtb3JlIGRpc3BsYXkgbW9kZSBzdXBwb3J0IG1wbGwgY29uZmlndXJhdGlvbiBmb3Igcmsz Mjg4Cj4KPiBDaGFuZ2VzIGluIHY5Ogo+IC0gbW92ZSBzb21lIHBoeSBjb25maWd1cmF0aW9uIHRv IHBsYXRmb3JtIGRyaXZlcgo+Cj4gQ2hhbmdlcyBpbiB2ODoKPiAtIGNvcnJlY3Qgc29tZSBzcGVs bGluZyBtaXN0YWtlCj4gLSBtb2RpZnkgZGRjLWkyYy1idXMgYW5kIGludGVycnVwdCBkZXNjcmlw dGlvbgo+IC0gQWRkIGRvY3VtZW50YXRpb24gZm9yIHJvY2tjaGlwIGR3IGhkbWkKPgo+IENoYW5n ZXMgaW4gdjc6Cj4gLSByZW1vdmUgdW51c2VkIHZhcmlhYmxlcyBmcm9tIHN0cnVjdHVyZSBkd19o ZG1pCj4gLSByZW1vdmUgYSB3cm9uZyBtb2RpZmljYXRpb24KPiAtIGFkZCBjb3B5cmlnaHRzIGZv ciBkd19oZG1pLWlteC5jCj4KPiBDaGFuZ2VzIGluIHY2Ogo+IC0gcmVhcnJhbmdlIHRoZSBwYXRj aCBvcmRlcgo+IC0gbW92ZSBzb21lIG1vZGlmaWNhdGlvbiB0byAgcGF0Y2gjNgo+IC0gcmVmYWN0 b3IgcmVnaXN0ZXIgYWNjZXNzIHdpdGhvdXQgcmVnX3NoaWZ0Cj4KPiBDaGFuZ2VzIGluIHY1Ogo+ IC0gcmVmYWN0b3IgcmVnLWlvLXdpZHRoCj4KPiBDaGFuZ2VzIGluIHY0Ogo+IC0gZml4IGNoZWNr cGF0Y2ggQ0hFQ0sKPiAtIGRlZmVyIHByb2JlIGRkYyBpMmMgYWRhcHRlcgo+Cj4gQ2hhbmdlcyBp biB2MzoKPiAtIHNwbGl0IG11bHRpLXJlZ2lzdGVyIGFjY2VzcyB0byBvbmUgaW5kZXBlbnQgcGF0 Y2gKPgo+IENoYW5nZXMgaW4gdjI6Cj4gLSB1c2UgZ2l0IGZvcm1hdCAtTSB0byBnZW5lcmF0ZSB0 aGVzZSBwYXRjaAo+Cj4gQW5keSBZYW4gKDExKToKPiAgICBzdGFnaW5nOiBpbXgtZHJtOiBpbXgt aGRtaTogbWFrZSBjaGVja3BhdGNoIGhhcHB5Cj4gICAgc3RhZ2luZzogaW14LWRybTogaW14LWhk bWk6IHJldHVybiBkZWZlciBpZiBjYW4ndCBnZXQgZGRjIGkyYyBhZGFwdGVyCj4gICAgc3RhZ2lu ZzogaW14LWRybTogaW14LWhkbWk6IGNvbnZlcnQgaW14LWhkbWkgdG8gZHJtX2JyaWRnZSBtb2Rl Cj4gICAgc3RhZ2luZzogaW14LWRybTogaW14LWhkbWk6IG1vdmUgaW14LWhkbWkgdG8gYnJpZGdl L2R3X2hkbWkKPiAgICBkdC1iaW5kaW5nczogYWRkIGRvY3VtZW50IGZvciBkd19oZG1pCj4gICAg ZHJtOiBicmlkZ2UvZHdfaGRtaTogYWRkIHN1cHBvcnQgZm9yIG11bHRpLWJ5dGUgcmVnaXN0ZXIg d2lkdGggYWNjZXNzCj4gICAgZHJtOiBicmlkZ2UvZHdfaGRtaTogYWRkIG1vZGVfdmFsaWQgc3Vw cG9ydAo+ICAgIGRybTogYnJpZGdlL2R3X2hkbWk6IGNsZWFyIGkyY21waHlfc3RhdDAgcmVnIGlu IGhkbWlfcGh5X3dhaXRfaTJjX2RvbmUKPiAgICBkcm06IGJyaWRnZS9kd19oZG1pOiBhZGQgZnVu Y3Rpb24gZHdfaGRtaV9waHlfZW5hYmxlX3NwYXJlCj4gICAgZHQtYmluZGluZ3M6IEFkZCBkb2N1 bWVudGF0aW9uIGZvciByb2NrY2hpcCBkdyBoZG1pCj4gICAgZHJtOiBicmlkZ2UvZHdfaGRtaTog YWRkIHJvY2tjaGlwIHJrMzI4OCBzdXBwb3J0Cj4KPiAgIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdz L2RybS9icmlkZ2UvZHdfaGRtaS50eHQgICAgIHwgIDQwICsrCj4gICAuLi4vZGV2aWNldHJlZS9i aW5kaW5ncy92aWRlby9kd19oZG1pLXJvY2tjaGlwLnR4dCB8ICA0MyArKwo+ICAgZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9LY29uZmlnICAgICAgICAgICAgICAgICAgICAgfCAgIDUgKwo+ICAgZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+ ICAgLi4uL2lteC1oZG1pLmMgPT4gZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jfSAgICAgICAgfCA3 NjcgKysrKysrKysrLS0tLS0tLS0tLS0tCj4gICAuLi4vaW14LWhkbWkuaCA9PiBncHUvZHJtL2Jy aWRnZS9kd19oZG1pLmh9ICAgICAgICB8ICAgNyArLQo+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tj aGlwL0tjb25maWcgICAgICAgICAgICAgICAgICAgfCAgMTAgKwo+ICAgZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL01ha2VmaWxlICAgICAgICAgICAgICAgICAgfCAgIDIgKy0KPiAgIGRyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9kd19oZG1pLXJvY2tjaGlwLmMgICAgICAgIHwgMzU1ICsrKysrKysr KysKPiAgIGRyaXZlcnMvc3RhZ2luZy9pbXgtZHJtL0tjb25maWcgICAgICAgICAgICAgICAgICAg IHwgICAxICsKPiAgIGRyaXZlcnMvc3RhZ2luZy9pbXgtZHJtL01ha2VmaWxlICAgICAgICAgICAg ICAgICAgIHwgICAyICstCj4gICBkcml2ZXJzL3N0YWdpbmcvaW14LWRybS9kd19oZG1pLWlteC5j ICAgICAgICAgICAgICB8IDI3NCArKysrKysrKwo+ICAgaW5jbHVkZS9kcm0vYnJpZGdlL2R3X2hk bWkuaCAgICAgICAgICAgICAgICAgICAgICAgfCAgNjAgKysKPiAgIDEzIGZpbGVzIGNoYW5nZWQs IDExMzkgaW5zZXJ0aW9ucygrKSwgNDI4IGRlbGV0aW9ucygtKQo+ICAgY3JlYXRlIG1vZGUgMTAw NjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hkbWku dHh0Cj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3ZpZGVvL2R3X2hkbWktcm9ja2NoaXAudHh0Cj4gICByZW5hbWUgZHJpdmVycy97c3RhZ2lu Zy9pbXgtZHJtL2lteC1oZG1pLmMgPT4gZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jfSAoNzAlKQo+ ICAgcmVuYW1lIGRyaXZlcnMve3N0YWdpbmcvaW14LWRybS9pbXgtaGRtaS5oID0+IGdwdS9kcm0v YnJpZGdlL2R3X2hkbWkuaH0gKDk5JSkKPiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvZHdfaGRtaS1yb2NrY2hpcC5jCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQg ZHJpdmVycy9zdGFnaW5nL2lteC1kcm0vZHdfaGRtaS1pbXguYwo+ICAgY3JlYXRlIG1vZGUgMTAw NjQ0IGluY2x1ZGUvZHJtL2JyaWRnZS9kd19oZG1pLmgKPgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51 eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155AbaKXO2O (ORCPT ); Mon, 24 Nov 2014 09:28:14 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:38594 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbaKXO2L (ORCPT ); Mon, 24 Nov 2014 09:28:11 -0500 X-Greylist: delayed 636 seconds by postgrey-1.27 at vger.kernel.org; Mon, 24 Nov 2014 09:28:10 EST X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: galak@codeaurora.org X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <41acc8039b8000f49ef7e32a4dc46c0d> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <54733DF3.7020609@rock-chips.com> Date: Mon, 24 Nov 2014 22:17:23 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll , mark.yao@rock-chips.com, Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH v12 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi References: <1415793593-5075-1-git-send-email-andy.yan@rock-chips.com> <1416221635-12797-1-git-send-email-andy.yan@rock-chips.com> In-Reply-To: <1416221635-12797-1-git-send-email-andy.yan@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ZubairLK, Russel King, Greg Kroah-Hartman , Philipp Zabel and Daniel: Do you have any further opinions or suggestions about the the current patch set? On 2014年11月17日 18:53, Andy Yan wrote: > We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) > use the interface compatible Designware HDMI IP, but they also have some > lightly differences, such as phy pll configuration, register width(imx hdmi > register is one byte, but rk3288 is 4 bytes width and can only be accessed > by word), 4K support(imx6 doesn't support 4k, but rk3288 does), and HDMI2.0 > support. > > To reuse the imx-hdmi driver, we make this patch set: > (1): fix some CodingStyle warning to make checkpatch happy > (2): convert imx-hdmi to drm_bridge > (3): move imx-hdmi to bridge/dw_hdmi, and split platform specific code > (4): extend dw_hdmi.c to support rk3288 hdmi > (5): add rockchip rk3288 platform specific code dw_hdmi-rockchip.c > > Changes in v12: > - refactor of_node_put(ddc_node) > - squash patch & > - add comment for the depend on patch > > Changes in v11: > - squash patch > - split form patch > - split from patch > > Changes in v10: > - split generic dw_hdmi.c improvements from patch#11 (add rk3288 support) > - add more display mode support mpll configuration for rk3288 > > Changes in v9: > - move some phy configuration to platform driver > > Changes in v8: > - correct some spelling mistake > - modify ddc-i2c-bus and interrupt description > - Add documentation for rockchip dw hdmi > > Changes in v7: > - remove unused variables from structure dw_hdmi > - remove a wrong modification > - add copyrights for dw_hdmi-imx.c > > Changes in v6: > - rearrange the patch order > - move some modification to patch#6 > - refactor register access without reg_shift > > Changes in v5: > - refactor reg-io-width > > Changes in v4: > - fix checkpatch CHECK > - defer probe ddc i2c adapter > > Changes in v3: > - split multi-register access to one indepent patch > > Changes in v2: > - use git format -M to generate these patch > > Andy Yan (11): > staging: imx-drm: imx-hdmi: make checkpatch happy > staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter > staging: imx-drm: imx-hdmi: convert imx-hdmi to drm_bridge mode > staging: imx-drm: imx-hdmi: move imx-hdmi to bridge/dw_hdmi > dt-bindings: add document for dw_hdmi > drm: bridge/dw_hdmi: add support for multi-byte register width access > drm: bridge/dw_hdmi: add mode_valid support > drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done > drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare > dt-bindings: Add documentation for rockchip dw hdmi > drm: bridge/dw_hdmi: add rockchip rk3288 support > > .../devicetree/bindings/drm/bridge/dw_hdmi.txt | 40 ++ > .../devicetree/bindings/video/dw_hdmi-rockchip.txt | 43 ++ > drivers/gpu/drm/bridge/Kconfig | 5 + > drivers/gpu/drm/bridge/Makefile | 1 + > .../imx-hdmi.c => gpu/drm/bridge/dw_hdmi.c} | 767 +++++++++------------ > .../imx-hdmi.h => gpu/drm/bridge/dw_hdmi.h} | 7 +- > drivers/gpu/drm/rockchip/Kconfig | 10 + > drivers/gpu/drm/rockchip/Makefile | 2 +- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++ > drivers/staging/imx-drm/Kconfig | 1 + > drivers/staging/imx-drm/Makefile | 2 +- > drivers/staging/imx-drm/dw_hdmi-imx.c | 274 ++++++++ > include/drm/bridge/dw_hdmi.h | 60 ++ > 13 files changed, 1139 insertions(+), 428 deletions(-) > create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > create mode 100644 Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt > rename drivers/{staging/imx-drm/imx-hdmi.c => gpu/drm/bridge/dw_hdmi.c} (70%) > rename drivers/{staging/imx-drm/imx-hdmi.h => gpu/drm/bridge/dw_hdmi.h} (99%) > create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > create mode 100644 drivers/staging/imx-drm/dw_hdmi-imx.c > create mode 100644 include/drm/bridge/dw_hdmi.h >