From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>,
Nadav Amit <namit@cs.technion.ac.il>,
Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host
Date: Mon, 24 Nov 2014 18:53:40 +0100 [thread overview]
Message-ID: <547370A4.3070707@redhat.com> (raw)
In-Reply-To: <DAC65E0B-06CC-4B34-85B2-72AD5F86826B@gmail.com>
On 24/11/2014 16:28, Nadav Amit wrote:
>
> Since kvm_load_guest_fpu is called before the guest_fpu is ever stored, there are 2 more problems that currently cause #GP:
> 1. XCOMP_BV[63] = 0
> 2. XSTATE_BV sets a bit (including bit 63) that is not set in XCOMP_BV (XCOMP_BV is initialised to zero).
>
> [see SDM 13.11 "OPERATION OF XRSTORS”]
>
> Once I initialise XCOMP_BV to (1ull << 63) | XSTATE_BV, the guest runs successfully.
> I have not checked any other qemu functionality that might be affected by the patch.
I posted patches that assume that QEMU calls KVM_SET_XSAVE early enough.
If this is not the case, can you cook up and post a patch to
kvm_arch_vcpu_init that fixes the remaining problem?
Paolo
next prev parent reply other threads:[~2014-11-24 17:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 18:31 [CFT PATCH 0/2] KVM: support XSAVES usage in the host Paolo Bonzini
2014-11-21 18:31 ` [CFT PATCH 1/2] kvm: x86: mask out XSAVES Paolo Bonzini
2014-11-21 18:31 ` [CFT PATCH 2/2] KVM: x86: support XSAVES usage in the host Paolo Bonzini
2014-11-21 20:06 ` Andy Lutomirski
2014-11-21 21:58 ` Paolo Bonzini
2014-11-24 2:10 ` Wanpeng Li
2014-11-24 10:07 ` Paolo Bonzini
2014-11-23 8:16 ` [CFT PATCH 0/2] KVM: " Nadav Amit
2014-11-23 8:24 ` Wanpeng Li
2014-11-23 8:31 ` Nadav Amit
2014-11-23 8:31 ` Nadav Amit
2014-11-23 8:34 ` Wanpeng Li
2014-11-24 11:39 ` Paolo Bonzini
2014-11-24 15:28 ` Nadav Amit
2014-11-24 15:54 ` Paolo Bonzini
2014-11-24 17:53 ` Paolo Bonzini [this message]
2014-11-24 18:31 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547370A4.3070707@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.