From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] Add support for Nyan Date: Mon, 24 Nov 2014 12:31:49 -0700 Message-ID: <547387A5.2060500@wwwdotorg.org> References: <1416757251-4588-1-git-send-email-sjg@chromium.org> <547365FB.7010408@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Bresticker , Allen Martin Cc: Simon Glass , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 11/24/2014 12:07 PM, Andrew Bresticker wrote: > On Mon, Nov 24, 2014 at 9:08 AM, Stephen Warren wrote: >> On 11/23/2014 08:40 AM, Simon Glass wrote: >>> >>> Add support for Tegra124 Nyan. Pinmux is based on norrin with a single >>> change for the reset GPIO. >> >> Allen, can you please confirm the reset GPIO setting for Norrin in the >> pinmux patch you sent? It seems as if the two boards truly are this >> identical, the reset pin would be too. > > Well Nyan and Norrin *are* identical - they're different names for the > same board. Oh. It's a bit of an epic fail to have multiple names for the exact same thing:-( When you say Nyan, are you talking about Nyan the family of boards (of which Big is one member), or do you consider Nyan to be a single board? Olof previously told me that Nyan was a family, of which Big was a member. So, I'm not sure if Norrin is another name for the family, or another name for a specific member. > It seems from the other patches though that this is for > Big (in which case the name of the config file should reflect that). Yes. All of the kernel, U-Boot, and tegra-pinmux-scripts (and tegra-uboot-flasher if relevant) should use the exact same name for the board. If what's currently known as Norrin in tegra-pinmux-scripts should actually be called Nyan or Nyan-big, we should rename it. > Either way, the reset GPIO (PI5) is configured the same across all > Nyan-based boards (Nyan/Norrin, Big, Blaze, Kitty) and I believe what > Simon has here is correct. If the entire pinmux identical across all of those boards too, or does it just happen that's true for this one pin? Hopefully Allen can comment on why the current Norrin values in tegra-pinmux-scripts differ then. I do recall that Venice2 had a similar issue, where the spreadsheet was actually wrong and SW had been fixed without updating the spreadsheet (grrr...) Perhaps the situation here is that simple too.