Re: [PATCH 3/3] esas2r: fix an oversight in setting return value

[Bradley Grove <bgrove@attotech.com>]

Acked-by: Bradley Grove <bgrove@attotech.com>

Thanks,
Brad

On 11/16/2014 08:35 AM, Tomas Henzl wrote:
> The patch moves an error code assigment to a 'default' case
> in the previous switch statement.
>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
>   drivers/scsi/esas2r/esas2r_ioctl.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/esas2r/esas2r_ioctl.c b/drivers/scsi/esas2r/esas2r_ioctl.c
> index c88b9f9491..baf913047b 100644
> --- a/drivers/scsi/esas2r/esas2r_ioctl.c
> +++ b/drivers/scsi/esas2r/esas2r_ioctl.c
> @@ -1524,9 +1524,12 @@ ioctl_done:
>   		case -EINVAL:
>   			ioctl->header.return_code = IOCTL_INVALID_PARAM;
>   			break;
> +
> +		default:
> +			ioctl->header.return_code = IOCTL_GENERAL_ERROR;
> +			break;
>   		}
>
> -		ioctl->header.return_code = IOCTL_GENERAL_ERROR;
>   	}
>
>   	/* Always copy the buffer back, if only to pick up the status */
>