Re: [PATCH] Add support for Nyan

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 11/24/2014 02:13 PM, Andrew Bresticker wrote:
> On Mon, Nov 24, 2014 at 11:31 AM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> On 11/24/2014 12:07 PM, Andrew Bresticker wrote:
>>>
>>> On Mon, Nov 24, 2014 at 9:08 AM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>>> wrote:
>>>>
>>>> On 11/23/2014 08:40 AM, Simon Glass wrote:
>>>>>
>>>>>
>>>>> Add support for Tegra124 Nyan. Pinmux is based on norrin with a single
>>>>> change for the reset GPIO.
>>>>
>>>>
>>>> Allen, can you please confirm the reset GPIO setting for Norrin in the
>>>> pinmux patch you sent? It seems as if the two boards truly are this
>>>> identical, the reset pin would be too.
>>>
>>>
>>> Well Nyan and Norrin *are* identical - they're different names for the
>>> same board.
>>
>>
>> Oh. It's a bit of an epic fail to have multiple names for the exact same
>> thing:-(
>>
>> When you say Nyan, are you talking about Nyan the family of boards (of which
>> Big is one member), or do you consider Nyan to be a single board? Olof
>> previously told me that Nyan was a family, of which Big was a member. So,
>> I'm not sure if Norrin is another name for the family, or another name for a
>> specific member.
>
> When I said Nyan above, I meant the actual Nyan board (which is also
> known as Norrin).  The Nyan family of boards is composed of Nyan (aka
> Norrin), Big (Acer Chromebook, which I believe this patch is referring
> to), Blaze, and Kitty.
>
>>> It seems from the other patches though that this is for
>>> Big (in which case the name of the config file should reflect that).
>>
>>
>> Yes. All of the kernel, U-Boot, and tegra-pinmux-scripts (and
>> tegra-uboot-flasher if relevant) should use the exact same name for the
>> board. If what's currently known as Norrin in tegra-pinmux-scripts should
>> actually be called Nyan or Nyan-big, we should rename it.
>
> No, the Norrin one is fine (other than the possible error Simon
> mentioned).  Calling it Nyan would be fine too.
>
> The file in this patch should be called Big or Nyan-Big, since it is
> for the Acer Chromebook.

Please let's call it nyan-big not just big, since the DT file in the 
kernel is nyan-big not just nyan.