All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Roger Chen <roger.chen@rock-chips.com>, heiko@sntech.de
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	mark.yao@rock-chips.com, eddie.cai@rock-chips.com
Subject: Re: [PATCH 4/4] GMAC: dts: enable gmac on RK3288 evb board
Date: Tue, 25 Nov 2014 17:59:12 +0800	[thread overview]
Message-ID: <547452F0.1080307@rock-chips.com> (raw)
In-Reply-To: <1416906549-26196-1-git-send-email-roger.chen@rock-chips.com>

Hi Roger,

The subject should prefix:
Arm: dts: rockchip: enable ...

On 11/25/2014 05:09 PM, Roger Chen wrote:
> enable gmac in rk3288-evb-rk808.dts
>
> Signed-off-by: Roger Chen <roger.chen@rock-chips.com>
> ---
>   arch/arm/boot/dts/rk3288-evb-rk808.dts |   22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> index d8c775e6..168b4fa 100644
> --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts
> +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> @@ -152,3 +152,25 @@
>   		};
>   	};
>   };
> +
> +&ext_gmac {
> +	clock-frequency = <125000000>;
> +	clock-output-names = "ext_gmac";
> +};
> +
> +&gmac {
> +	//pmu_regulator = "act_ldo5";
> +	//pmu_enable_level = <1>; //1->HIGH, 0->LOW
remove these unused code.
> +	power-gpio = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> +	reset-gpio = <&gpio4 7 GPIO_ACTIVE_LOW>;
> +	//phyirq-gpio = <&gpio4 2 GPIO_ACTIVE_LOW>;
same.
> +	phy-mode = "rgmii";
> +	clock_in_out = "input";
> +	assigned-clocks = <&cru SCLK_MAC>;
> +	assigned-clock-parents = <&ext_gmac>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&rgmii_pin>; /*&rmii_pin*/
same.

- Kever
> +	tx_delay = <0x30>;
> +	rx_delay = <0x10>;
> +	status = "ok";
> +};


      reply	other threads:[~2014-11-25  9:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25  9:09 [PATCH 4/4] GMAC: dts: enable gmac on RK3288 evb board Roger Chen
2014-11-25  9:59 ` Kever Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547452F0.1080307@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=eddie.cai@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.yao@rock-chips.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=roger.chen@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.