From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Date: Tue, 25 Nov 2014 12:27:30 +0000 Subject: Re: [patch] amdkfd: fix some error handling in ioctl Message-Id: <547475B2.9040108@amd.com> List-Id: References: <20141125102129.GB23215@mwanda> In-Reply-To: <20141125102129.GB23215@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Andrew Lewycky Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On 11/25/2014 12:21 PM, Dan Carpenter wrote: > There is a typo here so the errors from kfd_bind_process_to_device() > are not detected. > > Signed-off-by: Dan Carpenter > Patch is: Reviewed-by: Oded Gabbay And applied to my 3.19-next-wip tree Oded > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > index 64c73ba..c5dd0ae 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > @@ -236,7 +236,7 @@ static long kfd_ioctl_create_queue(struct file *filep, struct kfd_process *p, > mutex_lock(&p->mutex); > > pdd = kfd_bind_process_to_device(dev, p); > - if (IS_ERR(pdd) < 0) { > + if (IS_ERR(pdd)) { > err = PTR_ERR(pdd); > goto err_bind_process; > } > @@ -381,7 +381,7 @@ static long kfd_ioctl_set_memory_policy(struct file *filep, > mutex_lock(&p->mutex); > > pdd = kfd_bind_process_to_device(dev, p); > - if (IS_ERR(pdd) < 0) { > + if (IS_ERR(pdd)) { > err = PTR_ERR(pdd); > goto out; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [patch] amdkfd: fix some error handling in ioctl Date: Tue, 25 Nov 2014 14:27:30 +0200 Message-ID: <547475B2.9040108@amd.com> References: <20141125102129.GB23215@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0131.outbound.protection.outlook.com [65.55.169.131]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FDE46E15F for ; Tue, 25 Nov 2014 04:27:42 -0800 (PST) In-Reply-To: <20141125102129.GB23215@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Andrew Lewycky Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMTEvMjUvMjAxNCAxMjoyMSBQTSwgRGFuIENhcnBlbnRlciB3cm90ZToKPiBUaGVyZSBpcyBh IHR5cG8gaGVyZSBzbyB0aGUgZXJyb3JzIGZyb20ga2ZkX2JpbmRfcHJvY2Vzc190b19kZXZpY2Uo KQo+IGFyZSBub3QgZGV0ZWN0ZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxk YW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4KClBhdGNoIGlzOgpSZXZpZXdlZC1ieTogT2RlZCBH YWJiYXkgPG9kZWQuZ2FiYmF5QGFtZC5jb20+CkFuZCBhcHBsaWVkIHRvIG15IDMuMTktbmV4dC13 aXAgdHJlZQoKCU9kZWQKCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2Zk L2tmZF9jaGFyZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfY2hhcmRldi5j Cj4gaW5kZXggNjRjNzNiYS4uYzVkZDBhZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGtmZC9rZmRfY2hhcmRldi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRr ZmQva2ZkX2NoYXJkZXYuYwo+IEBAIC0yMzYsNyArMjM2LDcgQEAgc3RhdGljIGxvbmcga2ZkX2lv Y3RsX2NyZWF0ZV9xdWV1ZShzdHJ1Y3QgZmlsZSAqZmlsZXAsIHN0cnVjdCBrZmRfcHJvY2VzcyAq cCwKPiAgIAltdXRleF9sb2NrKCZwLT5tdXRleCk7Cj4KPiAgIAlwZGQgPSBrZmRfYmluZF9wcm9j ZXNzX3RvX2RldmljZShkZXYsIHApOwo+IC0JaWYgKElTX0VSUihwZGQpIDwgMCkgewo+ICsJaWYg KElTX0VSUihwZGQpKSB7Cj4gICAJCWVyciA9IFBUUl9FUlIocGRkKTsKPiAgIAkJZ290byBlcnJf YmluZF9wcm9jZXNzOwo+ICAgCX0KPiBAQCAtMzgxLDcgKzM4MSw3IEBAIHN0YXRpYyBsb25nIGtm ZF9pb2N0bF9zZXRfbWVtb3J5X3BvbGljeShzdHJ1Y3QgZmlsZSAqZmlsZXAsCj4gICAJbXV0ZXhf bG9jaygmcC0+bXV0ZXgpOwo+Cj4gICAJcGRkID0ga2ZkX2JpbmRfcHJvY2Vzc190b19kZXZpY2Uo ZGV2LCBwKTsKPiAtCWlmIChJU19FUlIocGRkKSA8IDApIHsKPiArCWlmIChJU19FUlIocGRkKSkg ewo+ICAgCQllcnIgPSBQVFJfRVJSKHBkZCk7Cj4gICAJCWdvdG8gb3V0Owo+ICAgCX0KPgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=