From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Date: Tue, 25 Nov 2014 13:15:53 +0000 Subject: Re: [patch] amdkfd: fix an error handling bug in pqm_create_queue() Message-Id: <54748109.4090504@amd.com> List-Id: References: <20141125102451.GC23215@mwanda> In-Reply-To: <20141125102451.GC23215@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Ben Goz Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On 11/25/2014 12:24 PM, Dan Carpenter wrote: > The call to kernel_queue_uninit(NULL) will trigger a BUG(), and also the > error code is incorrect. > > Fixes: 45102048f77e ('amdkfd: Add process queue manager module') > Signed-off-by: Dan Carpenter > Patch is: Reviewed-by: Oded Gabbay And applied to my 3.19-next-wip tree. Thanks! Oded > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > index c7859fc..7ce7a25 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > @@ -208,7 +208,7 @@ int pqm_create_queue(struct process_queue_manager *pqm, > case KFD_QUEUE_TYPE_DIQ: > kq = kernel_queue_init(dev, KFD_QUEUE_TYPE_DIQ); > if (kq = NULL) { > - kernel_queue_uninit(kq); > + retval = -ENOMEM; > goto err_create_queue; > } > kq->queue->properties.queue_id = *qid; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [patch] amdkfd: fix an error handling bug in pqm_create_queue() Date: Tue, 25 Nov 2014 15:15:53 +0200 Message-ID: <54748109.4090504@amd.com> References: <20141125102451.GC23215@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0108.outbound.protection.outlook.com [65.55.169.108]) by gabe.freedesktop.org (Postfix) with ESMTP id 33E776E7A9 for ; Tue, 25 Nov 2014 05:16:07 -0800 (PST) In-Reply-To: <20141125102451.GC23215@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Ben Goz Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMS8yNS8yMDE0IDEyOjI0IFBNLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IFRoZSBjYWxs IHRvIGtlcm5lbF9xdWV1ZV91bmluaXQoTlVMTCkgd2lsbCB0cmlnZ2VyIGEgQlVHKCksIGFuZCBh bHNvIHRoZQo+IGVycm9yIGNvZGUgaXMgaW5jb3JyZWN0Lgo+Cj4gRml4ZXM6IDQ1MTAyMDQ4Zjc3 ZSAoJ2FtZGtmZDogQWRkIHByb2Nlc3MgcXVldWUgbWFuYWdlciBtb2R1bGUnKQo+IFNpZ25lZC1v ZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KPgoKUGF0Y2gg aXM6ClJldmlld2VkLWJ5OiBPZGVkIEdhYmJheSA8b2RlZC5nYWJiYXlAYW1kLmNvbT4KQW5kIGFw cGxpZWQgdG8gbXkgMy4xOS1uZXh0LXdpcCB0cmVlLgpUaGFua3MhCgogICAgIE9kZWQKCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9wcm9jZXNzX3F1ZXVlX21h bmFnZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9wcm9jZXNzX3F1ZXVlX21h bmFnZXIuYwo+IGluZGV4IGM3ODU5ZmMuLjdjZTdhMjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3NfcXVldWVfbWFuYWdlci5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3NfcXVldWVfbWFuYWdlci5jCj4gQEAg LTIwOCw3ICsyMDgsNyBAQCBpbnQgcHFtX2NyZWF0ZV9xdWV1ZShzdHJ1Y3QgcHJvY2Vzc19xdWV1 ZV9tYW5hZ2VyICpwcW0sCj4gICAJY2FzZSBLRkRfUVVFVUVfVFlQRV9ESVE6Cj4gICAJCWtxID0g a2VybmVsX3F1ZXVlX2luaXQoZGV2LCBLRkRfUVVFVUVfVFlQRV9ESVEpOwo+ICAgCQlpZiAoa3Eg PT0gTlVMTCkgewo+IC0JCQlrZXJuZWxfcXVldWVfdW5pbml0KGtxKTsKPiArCQkJcmV0dmFsID0g LUVOT01FTTsKPiAgIAkJCWdvdG8gZXJyX2NyZWF0ZV9xdWV1ZTsKPiAgIAkJfQo+ICAgCQlrcS0+ cXVldWUtPnByb3BlcnRpZXMucXVldWVfaWQgPSAqcWlkOwo+Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==