From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] common/board_f: add setup of initial stack frame for MIPS
Date: Tue, 25 Nov 2014 14:32:40 +0100 [thread overview]
Message-ID: <547484F8.1080502@gmail.com> (raw)
In-Reply-To: <20141124222022.GX21184@bill-the-cat>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 24.11.2014 23:20, Tom Rini wrote:
>>>>
>>>> ok I'll send an updated patch.
>>>
>>> Thanks - and as I mentioned it seems wrong to write to a word
>>> above the top of the stack.
>>>
>>
>> I discard this patch. The only requirement for the stack pointer
>> on MIPS is alignment on a 8 Byte boundary. reserve_stacks already
>> aligns it to 16 Byte (gd->start_addr_sp &= ~0xf;).
>>
>> To make stack walking and backtraces working flawlessy in gdb, I
>> found another solution [1].
>>
>> [1] http://patchwork.ozlabs.org/patch/413182/
>
> And I of course missed this email while sorting out other problems
> with stuff I was applying. I'll just back this out and take the
> better fix.
>
hm, the patch landed in v2015.01-rc2. Do you want to create a revert
patch or shall I include one in my next pull request?
- --
- - Daniel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUdITqAAoJEPf1RifdDuszTuIIAJQzh2/EU16Hn+l/JC+TvJ3h
802FJMuKWeZRoF6NPrvZQ8x2SUloc2PfEOyQnMgUtChKOjzuba64Gk08ymzLQQ2Z
r7Iv4W3so/9jv41PLeuFpVCAzypRuOi01cXGOxJYLgj1U9QRxAmGXxyIM/v4IFP+
13ykcJLzxsp4qM12dEyBMQ+8uxysO3yjOwqEdk/q8agqttgnNd1ZjQ1Qzifs9udd
ITuxfuii4iwzM+XWg06Q01kC60hEHis4P/HHgHile/Wd0yKrX1rGPYozpvZO+mIr
r9w8Bnsdm/wgJOLX604MHMMjy6fkivrI7ZlCishEwMmOpnwElfnVwubjPFRQH0I=
=r3h1
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-11-25 13:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 22:46 [U-Boot] [PATCH 0/7] MIPS: convert all boards to generic-board Daniel Schwierzeck
2014-11-15 22:46 ` [U-Boot] [PATCH 1/7] common/board_f: add setup of initial stack frame for MIPS Daniel Schwierzeck
2014-11-17 6:24 ` Simon Glass
2014-11-19 16:59 ` Daniel Schwierzeck
2014-11-19 22:22 ` Simon Glass
2014-11-20 16:54 ` Daniel Schwierzeck
2014-11-20 17:22 ` Simon Glass
2014-11-21 20:46 ` Daniel Schwierzeck
2014-11-21 22:22 ` Simon Glass
2014-11-24 22:20 ` Tom Rini
2014-11-25 13:32 ` Daniel Schwierzeck [this message]
2014-11-24 22:12 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-15 22:46 ` [U-Boot] [PATCH 2/7] common/board_f: fix gcc warning on MIPS64 Daniel Schwierzeck
2014-11-17 6:26 ` Simon Glass
2014-11-24 22:12 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-15 22:46 ` [U-Boot] [PATCH 3/7] MIPS: dbau1x00: switch to generic board Daniel Schwierzeck
2014-11-15 22:46 ` [U-Boot] [PATCH 4/7] MIPS: pb1x00: " Daniel Schwierzeck
2014-11-15 22:46 ` [U-Boot] [PATCH 5/7] MIPS: qemu_mips: " Daniel Schwierzeck
2014-11-15 22:46 ` [U-Boot] [PATCH 6/7] MIPS: vct: " Daniel Schwierzeck
2014-11-16 9:17 ` Stefan Roese
2014-11-15 22:46 ` [U-Boot] [PATCH 7/7] MIPS: remove board.c Daniel Schwierzeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547484F8.1080502@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.