From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH for-xen-4.5] x86/pvh/vpmu: Disable VPMU for
	PVH guests
Date: Tue, 25 Nov 2014 09:38:30 -0500
Message-ID: <54749466.1020907@oracle.com>
References: <1416858554-1817-1-git-send-email-boris.ostrovsky@oracle.com>
	<54744FB2020000780004A935@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54744FB2020000780004A935@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 11/25/2014 03:45 AM, Jan Beulich wrote:
> @@ -1429,6 +1429,12 @@ int vlapic_init(struct vcpu *v)
>   
>       HVM_DBG_LOG(DBG_LEVEL_VLAPIC, "%d", v->vcpu_id);
>   
> +    if ( is_pvh_vcpu(v) )
> +    {
> +        vlapic->hw.disabled = VLAPIC_HW_DISABLED;


I did consider doing that but I thought that this flag is meant to be 
set when the guest clears MSR_IA32_APICBASE_ENABLE to disable APIC and 
therefore I'd be overloading it (the flag) in a way.

Regardless, do you think that disabling VPMU for PVH is worth anyway?

-boris



> +        return 0;
> +    }
> +
>       vlapic->pt.source = PTSRC_lapic;
>   
>       if (vlapic->regs_page == NULL)
>
>
>