From: Eric Blake <eblake@redhat.com>
To: "Xu, Quan" <quan.xu@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "lcapitulino@redhat.com" <lcapitulino@redhat.com>,
"armbru@redhat.com" <armbru@redhat.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Qemu-devel] [Xen-devel] [v2 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options
Date: Tue, 25 Nov 2014 09:30:53 -0700 [thread overview]
Message-ID: <5474AEBD.2040308@redhat.com> (raw)
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28890E8416DC@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
On 11/25/2014 06:51 AM, Xu, Quan wrote:
>>
>> Also, this message was not threaded properly; it appeared as a top-level
>> thread along with three other threads for its siblings, instead of all four
>> patches being in-reply-to the 0/4 cover letter.
>>
> Thanks Eric.
>
> Should I:
>
> V2 is version number,
> 1. $git format-patch --subject-prefix=v2 -ns --cover-letter master
> Then, edit 0000-cover-letter.patch
Rather than '--subject-prefix=v2', I prefer using '-v2'. The important
part is that you send the mails with 'git send-email' instead of doing
it by hand. In fact, you can do 'git send-email --annotate -v2
--cover-letter master' and skip the format-patch altogether, if you are
okay saving your cover letter edits to the point where you are sending
the mails.
>
> 2. $git format-patch --subject-prefix=v2 -4
> Then, commit these 4 patch and 0000-cover-letter.patch
I'm not sure what you meant by commit. You aren't adding the *.patch
files to a repository, but sending them as email.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-25 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 4:10 [Qemu-devel] [v2 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options Quan Xu
2014-11-24 17:19 ` Eric Blake
2014-11-24 17:19 ` [Qemu-devel] " Eric Blake
2014-11-24 17:31 ` Eric Blake
2014-11-25 13:51 ` Xu, Quan
2014-11-25 13:51 ` [Qemu-devel] [Xen-devel] " Xu, Quan
2014-11-25 16:30 ` [Qemu-devel] " Eric Blake
2014-11-25 16:30 ` Eric Blake [this message]
2014-11-26 2:03 ` [Qemu-devel] [Xen-devel] " Xu, Quan
2014-11-26 2:03 ` [Qemu-devel] " Xu, Quan
2014-11-24 17:31 ` Eric Blake
2014-11-25 13:52 ` Xu, Quan
2014-11-25 13:52 ` [Qemu-devel] " Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5474AEBD.2040308@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.