From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtJTW-0007wP-Ez for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:00:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtJTG-0007OM-1t for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:00:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtJTF-0007OC-Nu for qemu-devel@nongnu.org; Tue, 25 Nov 2014 12:00:09 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPH07pO025636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 25 Nov 2014 12:00:08 -0500 Message-ID: <5474AFCE.9080007@redhat.com> Date: Tue, 25 Nov 2014 09:35:26 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416899934-13952-1-git-send-email-kraxel@redhat.com> <87ioi3puut.fsf@blackfin.pond.sub.org> <20141125083700.GA26731@air.redhat.com> <87fvd7lcee.fsf@blackfin.pond.sub.org> In-Reply-To: <87fvd7lcee.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DkAuQQFLn5gpA7lR0TL4n2AMFvwJq5KgD" Subject: Re: [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Amos Kong Cc: Luiz Capitulino , qemu-devel@nongnu.org, Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DkAuQQFLn5gpA7lR0TL4n2AMFvwJq5KgD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/25/2014 04:58 AM, Markus Armbruster wrote: > Amos Kong writes: >=20 >> On Tue, Nov 25, 2014 at 09:06:34AM +0100, Markus Armbruster wrote: >>> Gerd Hoffmann writes: >>> >>>> Ongoing discussions on how we are going to specify the console, >>>> so tag the command as experiemntal so we can refine things in >>>> the 2.3 development cycle. >>>> >>>> Signed-off-by: Gerd Hoffmann >>>> --- >>>> qmp-commands.hx | 12 ++++++------ >>> >>> Don't you need to patch qapi-schema.json, too? >> >> Not necessary in function level. >=20 > s/need to/want to/? Yes, if you are going to mark the HMP command experimental, please also mark the QMP command as experimental. >=20 >>> Do we actually explain "x- means experimental" anywhere? Hmm, In my (not yet finished) series for improving qapi generation type safety, I have added: $ git grep -A1 'x-' docs/ =2E.. docs/qapi-code-gen.txt:Any command, type, or field name beginning with "x-" is marked docs/qapi-code-gen.txt-experimental, and may be withdrawn in a future release. Downstream =2E.. but I obviously need to find time to revisit my series since that text is not in upstream yet. >> >> What's the official way to make command experimental? >=20 > I think we have an understanding / convention that an "x-" prefix marks= > names as unstable API. But I can't find it spelled out anywhere. > Anyway, separate issue. Yep, and on my plate to finish it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DkAuQQFLn5gpA7lR0TL4n2AMFvwJq5KgD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUdK/OAAoJEKeha0olJ0NqNB8H/17WYpjKIbmi8rar8rWDXjfO AKIuWjuDxg+VeBW4UKqFbAnz4pLe2Ll5y/HQ1DLeIElsjtUirEJKCmC/6eDgllee C1rYwJSTh5SNCGJbcuOvMn/axUlYAIkNs0JmOsB4nBN2UwcfaiAUwrIQDM25k/CG Bk2V2ggHzFeg4AMwgesp4apN5SOJHWAK6hHymplux6FSfHYxyRidvhFyWEvEs8DI 2HC2i32HxIrfnxXmAPntk4rDJq7K1DqSJCTrQX+SV6/iEq+emys1w68U+20KZY+w 43nAcPaRgS21V1OvPBCWYfgRv3Fd0xS4y9LjJF3tSqNtnGG9Y+fhfxrAj0iPYE0= =BKD5 -----END PGP SIGNATURE----- --DkAuQQFLn5gpA7lR0TL4n2AMFvwJq5KgD--