Re: [Qemu-devel] [PATCH v2 3/3] block: Don't probe for unknown backing file format

[Max Reitz <mreitz@redhat.com>]

On 2014-11-25 at 18:12, Kevin Wolf wrote:
> If a qcow2 image specifies a backing file format that doesn't correspond
> to any format driver that qemu knows, we shouldn't fall back to probing,
> but simply error out.
>
> Not looking up the backing file driver in bdrv_open_backing_file(), but
> just filling in the "driver" option if it isn't there moves us closer to
> the goal of having everything in QDict options and gets us the error
> handling of bdrv_open(), which correctly refuses unknown drivers.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block.c                    |  7 +++---
>   tests/qemu-iotests/114     | 61 ++++++++++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/114.out | 13 ++++++++++
>   tests/qemu-iotests/group   |  1 +
>   4 files changed, 78 insertions(+), 4 deletions(-)
>   create mode 100755 tests/qemu-iotests/114
>   create mode 100644 tests/qemu-iotests/114.out

Reviewed-by: Max Reitz <mreitz@redhat.com>