Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs

[Arend van Spriel <arend@broadcom.com>]

On 11/25/14 20:23, Arend van Spriel wrote:
> On 11/25/14 20:16, Arend van Spriel wrote:
>> On 11/25/14 20:05, John W. Linville wrote:
>>> On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
>>>> On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
>>>>> On 11/24/14 22:50, John W. Linville wrote:
>>>>>> Hmmm...I'm not sure why, but this is causing problems for me...
>>>>>>
>>>>>> ERROR: "brcmu_boardrev_str"
>>>>>> [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
>>>>>
>>>>> I am confused as well. I did not have such an issue. The function is
>>>>> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and
>>>>> added it
>>>>> to the include file. Missing something? Also I don't see this issue
>>>>> over
>>>>> here. I will do a clean build on the wireless-next tree and see if I
>>>>> can
>>>>> reproduce this.
>>>>
>>>> I did a clean build after applying the patches in question, and I
>>>> still got the same issue at link time. I'll attach my .config for
>>>> you to try.
>>>
>>> I think that was too big...trying the compressed version...
>>
>> I received both. I assume he commit mentioned below is without the
>> patches.
>
> Nevermind. Just saw that commit is before the reverts.

Crap. I unintentionally put the function in #ifdef section. Will fix 
that and send a v2 patch.

Regards,
Arend

> Thanks,
> Arend
>
>> Regards,
>> Arend
>>
>>>> FWIW, I am building wireless-testing at commit
>>>> 733ea24c8c98d99c747b89710e520ac6e9f3951b.
>>>
>>> John
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html