From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 638E9E008D9; Tue, 25 Nov 2014 14:22:29 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from ptmx.org (ptmx.org [178.63.28.110]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4F1B5E0084E for ; Tue, 25 Nov 2014 14:22:22 -0800 (PST) Received: from [192.168.178.14] (chello062178118086.5.14.vie.surfer.at [62.178.118.86]) by ptmx.org (Postfix) with ESMTPSA id 006272CA83 for ; Tue, 25 Nov 2014 23:22:19 +0100 (CET) Message-ID: <5475011B.4030706@pseudoterminal.org> Date: Tue, 25 Nov 2014 23:22:19 +0100 From: Carlos Rafael Giani User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: meta-freescale@yoctoproject.org References: In-Reply-To: Subject: Re: [meta-fsl-demos][PATCH v2] packagegroup-fslc-gstreamer1.0-commercial: remove commercial recipe X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 22:22:29 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hm, I am not sure how this came to be. Anyway, you are correct that mpg123 is not part of -ugly, so this entry should be removed. However, there is a "gstreamer1.0-plugins-ugly-asfdemux" package from -ugly, which does belong here. Also, I think perhaps we could move this line from the -full to the -commercial packagegroup: ${@base_contains('LICENSE_FLAGS_WHITELIST', 'commercial', 'gstreamer1.0-libav', '', d)} I think this makes more sense. Comments? On 2014-11-21 17:58, Alexander Shashkevych wrote: > packagegroup-fslc-gstreamer1.0-commercial had a dependencies on > following missing packages: > > gstreamer1.0-plugins-ugly-mpg123 > gstreamer1.0-plugins-ugly-asfdemux > > Both of these packages are no longer provided by community. The > mpg123 plugin is now a part of bad plugins set and this leads to build > fail when commercial license is selected. > > This change removes packagegroup-fslc-gstreamer1.0-commercial recipe. > > Signed-off-by: Alexander Shashkevich > --- > .../packagegroup-fslc-gstreamer1.0-commercial.bb | 20 -------------------- > .../packagegroup-fslc-gstreamer1.0-full.bb | 1 - > 2 files changed, 21 deletions(-) > delete mode 100644 > recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb > > diff --git a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb > b/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb > deleted file mode 100644 > index f33c3d8..0000000 > --- a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-commercial.bb > +++ /dev/null > @@ -1,20 +0,0 @@ > -DESCRIPTION = "Freescale package group which provides audio and video plugins \ > - that are subject to retricted licensing and/or royalties and thus require \ > - the 'commercial' license whitelist flag" > -SUMMARY = "Freescale package group - set of GStreamer 1.0 plugins > with commercial licence flag" > -LICENSE = "MIT" > -LICENSE_FLAGS = "commercial" > -LIC_FILES_CHKSUM = > "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \ > - > file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" > - > -inherit packagegroup > - > -RDEPENDS_${PN} = " \ > - packagegroup-fslc-gstreamer1.0 \ > -" > - > -# Plugins from the -ugly collection which require the "commercial" > flag in LICENSE_FLAGS_WHITELIST to be set > -RDEPENDS_${PN} = " \ > - gstreamer1.0-plugins-ugly-mpg123 \ > - gstreamer1.0-plugins-ugly-asfdemux \ > -" > diff --git a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb > b/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb > index 4dd3d77..d99431a 100644 > --- a/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb > +++ b/recipes-multimedia/packagegroups/packagegroup-fslc-gstreamer1.0-full.bb > @@ -10,7 +10,6 @@ inherit packagegroup > > RDEPENDS_${PN} = " \ > packagegroup-fslc-gstreamer1.0 \ > - ${@base_contains('LICENSE_FLAGS_WHITELIST', 'commercial', > 'packagegroup-fslc-gstreamer1.0-commercial', '', d)} \ > gstreamer1.0-plugins-base-meta \ > gstreamer1.0-plugins-good-meta \ > gstreamer1.0-plugins-bad-meta \