From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: Problems using xl migrate Date: Tue, 25 Nov 2014 22:32:59 +0000 Message-ID: <5475039B.8010009@citrix.com> References: <54732EF5.5040607@citrix.com> <20141124140939.GA14073@zion.uk.xensource.com> <20141125091539.GA17596@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: M A Young , Wei Liu Cc: George Dunlap , Ian Jackson , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 25/11/2014 22:16, M A Young wrote: > > > On Tue, 25 Nov 2014, Wei Liu wrote: > >> On Tue, Nov 25, 2014 at 08:52:00AM +0000, M A Young wrote: >> [...] >>>> >>>> And the said patch has been applied (3460eeb3fc2) so we're fine. >>> >>> However that doesn't fix my crash. I tried with it applied and still >>> saw the >>> crash. I also tried 4.5-rc1 (without XSM to avoid my other issue) >>> and that >>> crashed as well. >>> >> >> And the log is still the same? If the crash happens in different >> location it might be another bug. > > Yes, it is the same crash. Going back to the dprintf command, > DPRINTF("************** pfn=%lx type=%lx gotcs=%08lx " > "actualcs=%08lx\n", pfn, pagebuf->pfn_types[pfn], > csum_page(region_base + i * PAGE_SIZE), > csum_page(buf)); > what does pagebuf->pfn_types[pfn] actually mean and how does it relate > to the type= it matches. I suspect it should be something else, eg. > pfn_type[pfn] which would give the page type corresponding to pfn. > > Michael Young Eugh - this code is horrible. (The migration v2 code is so much nicer). "pagebuf->pfn_types[pfn]" is completely bogus in this context, and should indeed be "pfn_type[pfn]" instead. The pagebuf->pfn_types[] array is up to 1024 entries long. Having said that, it is my firm opinion that verify mode is useless for anyone who isn't actively developing a migration stream (and even then, less useful than it would appear to be). I would skip the "--debug", as I don't believe it will help you at all in tracking down your issue. ~Andrew