All of lore.kernel.org
 help / color / mirror / Atom feed
From: drEagle <drEagle@doukki.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mvebu_mmc: Speed up access time
Date: Wed, 26 Nov 2014 07:20:19 +0100	[thread overview]
Message-ID: <54757123.9060001@doukki.net> (raw)
In-Reply-To: <1415043406-26618-1-git-send-email-mario.schuknecht@dresearch-fe.de>

Hi Mario,

I test this patch but it is unsuccessfull with the seevaplug :

After upgrade with U-Boot 2015.01-rc2-dirty (Nov 25 2014 - 08:10:39)                               
Marvell-Sheevaplug                                                              

Marvell>> mmc list                                                              
MVEBU_MMC: 0                                                                    
Marvell>> mmc part                                                              
Marvell>> mmc dev 0 1                                                           
Card did not respond to voltage select!                                         
Marvell>> mmc rescan                                                            
Marvell>> ext2ls mmc 0:1                                                        
** Bad device mmc 0 **                                                          
Marvell>> 

The same master branch (without your patch) work as before...

The udelay removal get the MVEBU_MMC driver bug with sheevaplug.

Regards,
G?rald

Le 03/11/2014 20:36, Mario Schuknecht a ?crit :
> Remove udelay, because card status is polled in a loop.
> 
> Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
> ---
>  drivers/mmc/mvebu_mmc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mmc/mvebu_mmc.c b/drivers/mmc/mvebu_mmc.c
> index 9f98c3f..2bf9444 100644
> --- a/drivers/mmc/mvebu_mmc.c
> +++ b/drivers/mmc/mvebu_mmc.c
> @@ -72,8 +72,6 @@ static int mvebu_mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>  	debug("cmdidx [0x%x] resp_type[0x%x] cmdarg[0x%x]\n",
>  	      cmd->cmdidx, cmd->resp_type, cmd->cmdarg);
>  
> -	udelay(10*1000);
> -
>  	debug("%s: cmd %d (hw state 0x%04x)\n", DRIVER_NAME,
>  	      cmd->cmdidx, mvebu_mmc_read(SDIO_HW_STATE));
>  
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141126/68353cc3/attachment.pgp>

      reply	other threads:[~2014-11-26  6:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03 19:36 [U-Boot] [PATCH] mvebu_mmc: Speed up access time Mario Schuknecht
2014-11-26  6:20 ` drEagle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54757123.9060001@doukki.net \
    --to=dreagle@doukki.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.