From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Date: Wed, 26 Nov 2014 08:57:10 +0000 Subject: Re: [patch] amdkfd: delete some dead code Message-Id: <547595E6.2030406@amd.com> List-Id: References: <20141125164329.GC19894@mwanda> In-Reply-To: <20141125164329.GC19894@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On 11/25/2014 06:43 PM, Dan Carpenter wrote: > This is dead code. We don't need to unbind here, we can just return > directly. > > Signed-off-by: Dan Carpenter > Patch is: Reviewed-by: Oded Gabbay And applied to my 3.19-next-wip tree. Thanks! Oded > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > index a17e2dd..b4f49ac 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c > @@ -348,11 +348,6 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev, > if (err < 0) > return ERR_PTR(err); > > - if (err < 0) { > - amd_iommu_unbind_pasid(dev->pdev, p->pasid); > - return ERR_PTR(err); > - } > - > pdd->bound = true; > > return pdd; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [patch] amdkfd: delete some dead code Date: Wed, 26 Nov 2014 10:57:10 +0200 Message-ID: <547595E6.2030406@amd.com> References: <20141125164329.GC19894@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0114.outbound.protection.outlook.com [157.56.111.114]) by gabe.freedesktop.org (Postfix) with ESMTP id EF8496E254 for ; Wed, 26 Nov 2014 00:57:19 -0800 (PST) In-Reply-To: <20141125164329.GC19894@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMS8yNS8yMDE0IDA2OjQzIFBNLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IFRoaXMgaXMg ZGVhZCBjb2RlLiAgV2UgZG9uJ3QgbmVlZCB0byB1bmJpbmQgaGVyZSwgd2UgY2FuIGp1c3QgcmV0 dXJuCj4gZGlyZWN0bHkuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNh cnBlbnRlckBvcmFjbGUuY29tPgo+IApQYXRjaCBpczoKUmV2aWV3ZWQtYnk6IE9kZWQgR2FiYmF5 IDxvZGVkLmdhYmJheUBhbWQuY29tPgpBbmQgYXBwbGllZCB0byBteSAzLjE5LW5leHQtd2lwIHRy ZWUuClRoYW5rcyEKCiAgICBPZGVkCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGtmZC9rZmRfcHJvY2Vzcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3By b2Nlc3MuYwo+IGluZGV4IGExN2UyZGQuLmI0ZjQ5YWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1ka2ZkL2tmZF9wcm9jZXNzLmMKPiBAQCAtMzQ4LDExICszNDgsNiBAQCBzdHJ1Y3Qga2Zk X3Byb2Nlc3NfZGV2aWNlICprZmRfYmluZF9wcm9jZXNzX3RvX2RldmljZShzdHJ1Y3Qga2ZkX2Rl diAqZGV2LAo+ICAJaWYgKGVyciA8IDApCj4gIAkJcmV0dXJuIEVSUl9QVFIoZXJyKTsKPiAgCj4g LQlpZiAoZXJyIDwgMCkgewo+IC0JCWFtZF9pb21tdV91bmJpbmRfcGFzaWQoZGV2LT5wZGV2LCBw LT5wYXNpZCk7Cj4gLQkJcmV0dXJuIEVSUl9QVFIoZXJyKTsKPiAtCX0KPiAtCj4gIAlwZGQtPmJv dW5kID0gdHJ1ZTsKPiAgCj4gIAlyZXR1cm4gcGRkOwo+IApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=