From: Lars-Peter Clausen <lars@metafoo.de>
To: Mike Looijmans <mike.looijmans@topic.nl>, pmeerw@pmeerw.net
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: iio:adc:ad799x driver broken after commit "Write default config on probe and reset alert status on probe"
Date: Wed, 26 Nov 2014 11:07:40 +0100 [thread overview]
Message-ID: <5475A66C.2090204@metafoo.de> (raw)
In-Reply-To: <5475A1A0.5060003@topic.nl>
On 11/26/2014 10:47 AM, Mike Looijmans wrote:
> On 11/25/2014 03:03 PM, Lars-Peter Clausen wrote:
>> On 11/25/2014 09:12 AM, Mike Looijmans wrote:
>>> After this commit:
>>>
>>> iio:adc:ad799x: Write default config on probe and reset alert status on
>>> probe
>>>
>>> writing ALERT_EN and BUSY_ALERT to the chip config register clears
>>> pending alerts, BUSY_ALERT is cleared when reading back the register
>>>
>>> The AD7999 on our board no longer functions, reading the in_voltage*_raw
>>> sysfiles always returns "255" after this.
>>>
>>> I reverted the commit, and that fixed the problem for me.
>>
>> I suspect that there is something going wrong when reading back the config
>> register, can you check the attached patch and see what the output is?
>>
>> Thanks,
>> - Lars
>>
>
> The attached patch delivered the following output (using the current head
> code):
>
> ad799x 1-0029: config: b 0
>
Yea, kind of what I expected based on your description. Looking at the
datasheet it seems the ad7999 doesn't even support register read back which
would explain the issue. I'll try to find a board and see if I can fix it.
- Lars
prev parent reply other threads:[~2014-11-26 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <547439F9.7070903@topic.nl>
2014-11-25 14:03 ` iio:adc:ad799x driver broken after commit "Write default config on probe and reset alert status on probe" Lars-Peter Clausen
2014-11-26 9:47 ` Mike Looijmans
2014-11-26 10:07 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5475A66C.2090204@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.