From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtagI-0005O8-0t for qemu-devel@nongnu.org; Wed, 26 Nov 2014 06:22:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtagB-00058D-Rg for qemu-devel@nongnu.org; Wed, 26 Nov 2014 06:22:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtagB-00057R-JV for qemu-devel@nongnu.org; Wed, 26 Nov 2014 06:22:39 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAQBMb4F004734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 26 Nov 2014 06:22:38 -0500 Message-ID: <5475B7FB.9030406@redhat.com> Date: Wed, 26 Nov 2014 12:22:35 +0100 From: Max Reitz MIME-Version: 1.0 References: <1416944800-17919-1-git-send-email-jsnow@redhat.com> <1416944800-17919-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1416944800-17919-2-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [2.3 PATCH v7 01/10] qapi: Add optional field "name" to block dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: Fam Zheng On 2014-11-25 at 20:46, John Snow wrote: > From: Fam Zheng > > This field will be set for user created dirty bitmap. Also pass in an > error pointer to bdrv_create_dirty_bitmap, so when a name is already > taken on this BDS, it can report an error message. This is not global > check, two BDSes can have dirty bitmap with a common name. > > Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will > be used later when other QMP commands want to reference dirty bitmap by > name. > > Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap. > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > --- > block-migration.c | 2 +- > block.c | 32 +++++++++++++++++++++++++++++++- > block/mirror.c | 2 +- > include/block/block.h | 7 ++++++- > qapi/block-core.json | 4 +++- > 5 files changed, 42 insertions(+), 5 deletions(-) Reviewed-by: Max Reitz