From: Lars-Peter Clausen <lars@metafoo.de>
To: Zidan Wang <b50113@freescale.com>, broonie@kernel.org
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
ckeepax@opensource.wolfsonmicro.com, Li.Xiubo@freescale.com,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after software reset
Date: Wed, 26 Nov 2014 12:33:10 +0100 [thread overview]
Message-ID: <5475BA76.8080809@metafoo.de> (raw)
In-Reply-To: <1416999740-21805-1-git-send-email-b50113@freescale.com>
On 11/26/2014 12:02 PM, Zidan Wang wrote:
> When shared_lrclk is set, LRCM will be enabled. But the following software
> reset in wm8960_probe will reset it to the default state. So LRCM operation
> should after software reset.
It's probably a better idea to move the reset (together with the other
register updates) to the I2C driver probe.
- Lars
next prev parent reply other threads:[~2014-11-26 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 11:02 [PATCH] ASoC: wm8960: LRCM operation should after software reset Zidan Wang
2014-11-26 11:02 ` [alsa-devel][PATCH] " Zidan Wang
2014-11-26 11:33 ` Lars-Peter Clausen [this message]
2014-11-26 16:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5475BA76.8080809@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b50113@freescale.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.