All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/3] ACPI / processor: remove incorrect comparison of phys_id
Date: Wed, 26 Nov 2014 12:23:43 +0000	[thread overview]
Message-ID: <5475C64F.7010603@arm.com> (raw)
In-Reply-To: <27257905.ShLUYyq0Be@vostro.rjw.lan>

Hi Rafael,

On 25/11/14 23:11, Rafael J. Wysocki wrote:
> On Tuesday, November 25, 2014 02:48:48 PM Sudeep Holla wrote:
>> phys_id in acpi_processor structure is unsigned 32-bit integer,
>> comparing it with signed value is incorrect.
>>
>> This patch removes that incorrect comparision in
>> acpi_processor_hotadd_init as the lone user of this function is
>> already checking for correctness of phys_id before calling it.
>>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> This one depens on commits I've dropped due to conflicts with the tip
> tree.
>
> They'll need to be rebased on top of current linux-next and resent.
>

I have rebased but will hold off until your response to Hanjun's concern.

> I can take patches [2-3/3], though.

Thanks.

Regards,
Sudeep


  reply	other threads:[~2014-11-26 12:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 14:48 [PATCH 0/3] ACPI/processor: trivial fixes Sudeep Holla
2014-11-25 14:48 ` [PATCH 1/3] ACPI / processor: remove incorrect comparison of phys_id Sudeep Holla
2014-11-25 23:11   ` Rafael J. Wysocki
2014-11-26 12:23     ` Sudeep Holla [this message]
2014-11-26  9:53   ` Hanjun Guo
2014-11-26 10:33     ` Sudeep Holla
2014-11-26 22:26       ` Rafael J. Wysocki
2014-11-27  2:43         ` Hanjun Guo
2014-11-28 19:05         ` Sudeep Holla
2014-11-28 23:26           ` Rafael J. Wysocki
2015-02-13  7:56             ` Hanjun Guo
2015-02-16 10:08               ` Sudeep Holla
2015-02-17 15:01                 ` Hanjun Guo
2015-02-17 15:20                   ` Sudeep Holla
2014-11-25 14:48 ` [PATCH 2/3] ACPI / processor: remove unused variabled from acpi_processor_power structure Sudeep Holla
2014-11-25 14:48 ` [PATCH 3/3] ACPI / cpuidle: avoid assigning signed errno to acpi_status Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5475C64F.7010603@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.