From: John Harrison <John.C.Harrison@Intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Check locking in i915_gem_request_unreference
Date: Wed, 26 Nov 2014 12:41:43 +0000 [thread overview]
Message-ID: <5475CA87.10601@Intel.com> (raw)
In-Reply-To: <20141126103933.GB10194@nuc-i3427.alporthouse.com>
On 26/11/2014 10:39, Chris Wilson wrote:
> On Wed, Nov 26, 2014 at 10:28:13AM +0100, Daniel Vetter wrote:
>> With refcounting it looks like you can just drop that refcount, but
>> that's not really the case. So make sure no one forgets.
>>
>> Motivated by the unlocked call in the mmio flip code.
> I had an unlocked variant for exactly this purpose (and a few others
> where we do not want to take the lock again) and so also had the WARN
> inside i915_request_free.
>
> Drop the _gem_, the requests are lower level than GEM itself.
> -Chris
>
Daniel: Should I fold the WARN_ON patch into my patch series and repost?
Chris: Are you saying that you want an extra patch to rename
'drm_i915_gem_request' to 'drm_i915_request' throughout the entire driver?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-26 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 9:28 [PATCH] drm/i915: Check locking in i915_gem_request_unreference Daniel Vetter
2014-11-26 10:39 ` Chris Wilson
2014-11-26 12:41 ` John Harrison [this message]
2014-11-26 12:46 ` Chris Wilson
2014-11-26 12:48 ` Daniel Vetter
2014-11-26 12:42 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5475CA87.10601@Intel.com \
--to=john.c.harrison@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.