From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at)
 by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux))
 id 1Xtckv-0006U0-Fa
 for linux-mtd@lists.infradead.org; Wed, 26 Nov 2014 13:35:44 +0000
Message-ID: <5475D713.9050101@nod.at>
Date: Wed, 26 Nov 2014 14:35:15 +0100
From: Richard Weinberger <richard@nod.at>
MIME-Version: 1.0
To: Fabio Estevam <festevam@gmail.com>,
 Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH] mtd: gpmi: Remove noisy error message
References: <1415721691-14073-1-git-send-email-fabio.estevam@freescale.com>	<CAFLxGvwgy-+5K63re678JwcSy2-bNRtDHXiW-1Ve+1En5xHFYg@mail.gmail.com>	<CAOMZO5A2JJ+HAomy6qDZ6xLf2Bep8R6Jd7O5+N2GkQvtHhm8fg@mail.gmail.com>	<54626AF4.4090306@nod.at>	<CAOMZO5AXMjTPPnQtnZUxRmBezoq32wLSCX0iJ30PWa1dZhJ7qQ@mail.gmail.com>	<54626D23.1080003@nod.at>	<CAOMZO5C3STv-ZsTyXhxs2rhUMM7nu+kuzdAtV_Fo9c5azdeAuA@mail.gmail.com>	<20141126031823.GQ24364@ld-irv-0074>
 <CAOMZO5C_9er34oqGCYWfhe3NvmJXfqC21s_Uiset7_y7NKHXXA@mail.gmail.com>
In-Reply-To: <CAOMZO5C_9er34oqGCYWfhe3NvmJXfqC21s_Uiset7_y7NKHXXA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
 "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
 Huang Shijie <shijie8@gmail.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Am 26.11.2014 um 12:44 schrieb Fabio Estevam:
> On Wed, Nov 26, 2014 at 1:18 AM, Brian Norris
> <computersforpeace@gmail.com> wrote:
>> On Tue, Nov 11, 2014 at 06:16:29PM -0200, Fabio Estevam wrote:
>>> BTW, I don't see any other nand driver that prints error on the probe
>>> error path like this one.
>>
>> You're probably still going to see failure prints like
>>
>>   nand: No NAND device found
>>
>> in nand_scan_ident(), right? Or does driver probe fail earlier than that
>> somehow?
> 
> Yes, this is what I get currently:
> 
> [    1.645433] nand: No NAND device found
> [    1.650372] gpmi-nand 8000c000.gpmi-nand: driver registration failed: -19
> 
> In my opinion the "No NAND device found" is enough.

If we remove the said log message and one really has a NAND installed which fails
to probe will he notice that and get the correct error code printed?
If yes, the removal won't hurt.

My point is that having non-existing hardware in the device does not make much sense.
Lot's of DTs are very generic and carry a lot of unused stuff with them,
but this is not a good practice as DTs should describe the actual hardware and not
all possible board variants.

Thanks,
//richard