From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Sakamoto Subject: Re: [PATCH 1/2] ALSA: firewire-lib: remove rx_blocks_for_midi quirk Date: Wed, 26 Nov 2014 23:22:09 +0900 Message-ID: <5475E211.3040106@sakamocchi.jp> References: <5474FA18.7000501@ladisch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp310.phy.lolipop.jp (smtp310.phy.lolipop.jp [210.157.22.78]) by alsa0.perex.cz (Postfix) with ESMTP id 053282652C3 for ; Wed, 26 Nov 2014 15:22:14 +0100 (CET) In-Reply-To: <5474FA18.7000501@ladisch.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch , Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Clemens, On Nov 26 2014 06:52, Clemens Ladisch wrote: > There are several devices that expect to receive MIDI data only in the > first eight data blocks of a packet. If the driver restricts the data > rate to the allowed rate (as mandated by the specification, but not yet > implemented by this driver), this happens naturally. Therefore, there > is no reason to ever try to use more data packets with any device. > > Signed-off-by: Clemens Ladisch > --- > sound/firewire/amdtp.c | 10 +++++++--- > sound/firewire/amdtp.h | 3 --- > sound/firewire/bebob/bebob_stream.c | 7 ------- > sound/firewire/fireworks/fireworks_stream.c | 5 ----- > 4 files changed, 7 insertions(+), 18 deletions(-) Can I ask your opinion about applying this patch to devices with non-blocking mode? At least, your comment of this patch is for blocking mode (the fixed number of data blocks in a packet). Regards Takashi Sakamoto o-takashi@sakamocchi.jp