All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Arianna Avanzini <avanzini.arianna@gmail.com>,
	gregkh@linuxfoundation.org
Cc: jslaby@suse.cz, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty, serial, 8250: remove __init from function serial8250_console_setup()
Date: Wed, 26 Nov 2014 09:25:56 -0500	[thread overview]
Message-ID: <5475E2F4.7090603@hurleysoftware.com> (raw)
In-Reply-To: <1416954082-1755-1-git-send-email-avanzini.arianna@gmail.com>

On 11/25/2014 05:21 PM, Arianna Avanzini wrote:
> Some RS232 adapters handled by this driver are hotpluggable. The function
> serial8250_console_setup() is called during device init and is defined with
> the __init macro. In case the driver is built-in, hotplugging the device after
> the initialization phase has been completed (and the related memory has been
> freed) results in a kernel crash.
> This commit fixes the issue by removing __init from the function definition.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

  reply	other threads:[~2014-11-26 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 18:00 [PATCH RFC] tty, serial, 8250: remove __init from function serial8250_console_setup() Arianna Avanzini
2014-11-25 17:51 ` Greg KH
2014-11-25 22:18   ` Arianna Avanzini
2014-11-25 22:21   ` [PATCH] " Arianna Avanzini
2014-11-26 14:25     ` Peter Hurley [this message]
2014-11-26 17:26     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5475E2F4.7090603@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=avanzini.arianna@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.