From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line condition
Date: Wed, 26 Nov 2014 09:39:13 -0700 [thread overview]
Message-ID: <54760231.9070004@redhat.com> (raw)
In-Reply-To: <1417018829-15002-2-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
On 11/26/2014 09:20 AM, Max Reitz wrote:
> CODING_STYLE states the following about braces around blocks:
>
>> The opening brace is on the line that contains the control flow
>> statement that introduces the new block; [...]
>
> This is obviously impossible with multi-line conditions. Therefore,
> CODING_STYLE does not make any clear statement about where to put the
> opening brace after a multi-line condition.
I'll leave review of this one to others (personally, I'm 80:20 against
applying it, but my vote is very weak if you scale it by the percentage
of actual C code contributions existing in the tree under my name - so
I'll live with majority rules).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-11-26 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 16:20 [Qemu-devel] [PATCH v4 0/6] block: Relative backing files Max Reitz
2014-11-26 16:20 ` [Qemu-devel] [PATCH v4 1/6] checkpatch: Brace handling on multi-line condition Max Reitz
2014-11-26 16:39 ` Eric Blake [this message]
2014-11-26 16:20 ` [Qemu-devel] [PATCH v4 2/6] block: Get full backing filename from string Max Reitz
2014-11-26 16:20 ` [Qemu-devel] [PATCH v4 3/6] block: JSON filenames and relative backing files Max Reitz
2014-11-26 16:40 ` Eric Blake
2014-11-26 16:20 ` [Qemu-devel] [PATCH v4 4/6] block: Relative backing file for image creation Max Reitz
2014-11-26 16:20 ` [Qemu-devel] [PATCH v4 5/6] block/vmdk: Relative backing file for creation Max Reitz
2014-11-26 16:20 ` [Qemu-devel] [PATCH v4 6/6] iotests: Add test for relative backing file names Max Reitz
2014-12-15 9:44 ` [Qemu-devel] [PATCH v4 0/6] block: Relative backing files Max Reitz
2014-12-19 15:13 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54760231.9070004@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.