All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Small <tim@seoss.co.uk>
To: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@infradead.org>
Cc: tim@buttersideup.com, Wakko Warner <wakko@animx.eu.org>,
	linux-scsi@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	Tim Waugh <tim@cyberelk.net>
Subject: Re: [PATCH 0/4] Fix performance burning or extracting audio etc. from multiple optical drives.
Date: Wed, 26 Nov 2014 20:34:20 +0000	[thread overview]
Message-ID: <5476394C.3050606@seoss.co.uk> (raw)
In-Reply-To: <5475F2DD.9030906@seoss.co.uk>

On 26/11/14 15:33, Tim Small wrote:
> I decided to exercise the eject code path a bit more by triggering
> simultaneous eject commands on all 11 optical drives in my test box,
> followed by simultaneous close-tray commands, repeatedly.
...
>
> Unfortunately running these tests did eventually make all further
> attempts to open /dev/sr* block on my test box.
>
> I've stared at the code for a while, but not making any headway
> currently, except that a blocking blk_execute_rq (called by
> test_unit_ready) is then causing all over cdrom open/close calls to
> block (because sr_mutex is held by sr_block_open(), and in turn calls
> check_disk_change... scsi_test_unit_ready).
>
> How do I work out why blk_execute_rq is blocking?
>
> # ps -l 3779 2383 3780
> F S   UID   PID  PPID  C PRI  NI ADDR SZ WCHAN  TTY        TIME CMD
> 1 D     0  2383     2  0  80   0 -     0 blk_ex ?          0:00 [kworker/1:2]
> 0 D     0  3779  1034  0  80   0 -  1057 blk_ex pts/0      0:00 eject -t /dev/sr7
> 0 D     0  3780  1034  0  80   0 -     0 sr_blo pts/0      0:00 [eject]
>
>
>
> /proc/3779/stack-[<ffffffff812e47cb>] blk_execute_rq+0x16b/0x210
> /proc/3779/stack-[<ffffffffa0291cb1>] scsi_execute+0x141/0x1f0 [scsi_mod]
> /proc/3779/stack-[<ffffffffa0293e1e>] scsi_execute_req_flags+0x8e/0x100 [scsi_mod]

> /proc/2383/stack-[<ffffffff812e47cb>] blk_execute_rq+0x16b/0x210
> /proc/2383/stack-[<ffffffffa0291cb1>] scsi_execute+0x141/0x1f0 [scsi_mod]
> /proc/2383/stack-[<ffffffffa0293e1e>] scsi_execute_req_flags+0x8e/0x100 [scsi_mod]
> /proc/2383/stack-[<ffffffffa02944f3>] scsi_test_unit_ready+0x83/0x130 [scsi_mod]

An extra data point, the drive is showing busy:

# cat /sys/block/sr7/device/device_busy
1

I was wondering if this might be an unrelated bug in the drive or host
adaptor driver?

This device is attached to an old PCI card using pata_pdc2027x, and has
an old firmware version, so I'm going to try and change both of those
things and try again.

Tim.

  reply	other threads:[~2014-11-26 20:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 13:25 Very slow throughput when using cdparanoia on two SATA CDROM drives with /dev/sr but not /dev/sg Tim Small
2014-11-07 21:37 ` Wakko Warner
2014-11-20  6:34   ` Christoph Hellwig
2014-11-20  8:16     ` Tim Small
2014-11-21 10:02       ` Christoph Hellwig
2014-11-25 14:09         ` [PATCH 0/4] Fix performance burning or extracting audio etc. from multiple optical drives Tim Small
2014-11-25 16:26           ` Christoph Hellwig
2014-11-25 16:30             ` Jens Axboe
2014-11-25 16:32               ` Christoph Hellwig
2014-11-25 16:36                 ` Jens Axboe
2014-11-26 15:33               ` Tim Small
2014-11-26 20:34                 ` Tim Small [this message]
2014-11-26 23:01                 ` Julian Calaby
2014-11-27  7:08                   ` Tim Small
2015-11-05  1:38           ` Wakko Warner
2015-11-05  9:36             ` Tim Small
2014-11-25 14:09         ` [PATCH 1/4] enable cdrom_ioctl() to be called without holding ex-BKL mutexes Tim Small
2014-11-25 14:09         ` [PATCH 2/4] Remove ex-BKL lock from ioctl path; fix simultaneous record on >1 drive Tim Small
2014-11-25 14:09         ` [PATCH 3/4] " Tim Small
2014-11-25 14:09         ` [PATCH 4/4] " Tim Small

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5476394C.3050606@seoss.co.uk \
    --to=tim@seoss.co.uk \
    --cc=axboe@fb.com \
    --cc=bp@alien8.de \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=tim@buttersideup.com \
    --cc=tim@cyberelk.net \
    --cc=wakko@animx.eu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.