From: Andrew Cooper <andrew.cooper3@citrix.com>
To: M A Young <m.a.young@durham.ac.uk>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] fix segfault in xl migrate --debug
Date: Wed, 26 Nov 2014 21:19:04 +0000 [thread overview]
Message-ID: <547643C8.5000806@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1411261906310.18561@procyon.dur.ac.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1077 bytes --]
On 26/11/2014 19:54, M A Young wrote:
> If differences are found during the verification phase of xl migrate
> --debug then it is likely to crash with a segfault because the bogus
> pagebuf->pfn_types[pfn] is used in a print statement instead of
> pfn_type[pfn] .
>
> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
>
>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> xl migrate --debug can segfault because pagebuf->pfn_types[pfn] is
> used in a print statement instead of pfn_type[pfn]
>
> --- xen-4.5.0-rc1/tools/libxc/xc_domain_restore.c.orig 2014-10-24 15:22:40.000000000 +0100
> +++ xen-4.5.0-rc1/tools/libxc/xc_domain_restore.c 2014-11-25 21:01:16.604081467 +0000
> @@ -1404,7 +1404,7 @@
> int v;
>
> DPRINTF("************** pfn=%lx type=%lx gotcs=%08lx "
> - "actualcs=%08lx\n", pfn, pagebuf->pfn_types[pfn],
> + "actualcs=%08lx\n", pfn, pfn_type[pfn],
> csum_page(region_base + i * PAGE_SIZE),
> csum_page(buf));
>
[-- Attachment #1.2: Type: text/html, Size: 2157 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-11-26 21:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 19:54 [PATCH] fix segfault in xl migrate --debug M A Young
2014-11-26 21:19 ` Andrew Cooper [this message]
2014-11-28 12:09 ` Ian Campbell
2014-12-01 21:11 ` Konrad Rzeszutek Wilk
2014-12-16 20:38 ` M A Young
2014-12-16 21:55 ` Wei Liu
2014-12-16 22:04 ` M A Young
2014-12-16 22:55 ` Wei Liu
2014-12-18 10:18 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547643C8.5000806@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.