Re: [PATCH 1/2] ACPI / table: Add new function to get table entries

[Hanjun Guo <hanjun.guo@linaro.org>]

On 2014-11-27 6:14, Rafael J. Wysocki wrote:
> On Wednesday, November 26, 2014 10:01:13 PM Hanjun Guo wrote:
>> From: Ashwin Chaugule <ashwin.chaugule@linaro.org>
>>
>> The acpi_table_parse() function has a callback that
>> passes a pointer to a table_header. Add a new function
>> which takes this pointer and parses its entries. This
>> eliminates the need to re-traverse all the tables for
>> each call. e.g. as in acpi_table_parse_madt() which is
>> normally called after acpi_table_parse().
>>
>> Acked-by: Grant Likely <grant.likely@linaro.org>
>> Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org>
>> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
>>  drivers/acpi/tables.c | 63 +++++++++++++++++++++++++++++++++++----------------
>>  include/linux/acpi.h  |  4 ++++
>>  2 files changed, 48 insertions(+), 19 deletions(-)
>>
>> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
>> index 6d5a6cd..f1debe9 100644
>> --- a/drivers/acpi/tables.c
>> +++ b/drivers/acpi/tables.c
>> @@ -190,30 +190,24 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>>  	}
>>  }
>>  
>> -
>>  int __init
>> -acpi_table_parse_entries(char *id,
>> -			     unsigned long table_size,
>> -			     int entry_id,
>> -			     acpi_tbl_entry_handler handler,
>> -			     unsigned int max_entries)
>> +acpi_parse_entries(char *id, unsigned long table_size,
> 
> Why isn't this static?  Are you going to use it somewhere else?

Yes, we will use it in the following patches to parse
entries in static ACPI tables.

Thanks
Hanjun